Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ref): add conditions to git-sync-controller #10

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Mar 20, 2023

No description provided.

@Skarlso Skarlso force-pushed the apply-conditions branch 2 times, most recently from ce4685b to 3f7a781 Compare March 20, 2023 08:42
@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 20, 2023

Failure condition test:

Status:                                                                                                                            
│   Conditions:                                                                                                                      
│     Last Transition Time:  2023-03-20T12:22:10Z                                                                                    │
│     Message:               failed to find authentication secret: Secret "git-sync-secret" not found                                │
│     Observed Generation:   1                                                                                                       │
│     Reason:                AuthenticateGetFailed                                                                                   │
│     Status:                False                                                                                                   │
│     Type:                  Ready    

Copy link
Contributor

@phoban01 phoban01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change

api/v1alpha1/condition_types.go Outdated Show resolved Hide resolved
controllers/gitsync_controller.go Outdated Show resolved Hide resolved
@Skarlso Skarlso merged commit d9322c0 into main Mar 22, 2023
@Skarlso Skarlso deleted the apply-conditions branch March 22, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants