feat: create branch protection rules for gitea (#44)

* feat: create branch protection rules for gitea * Update pkg/providers/gitea/gitea.go Co-authored-by: Piaras Hoban <[email protected]> --------- Co-authored-by: Piaras Hoban <[email protected]>
open-component-model · Jun 8, 2023 · e185b91 · e185b91
1 parent df6be72
commit e185b91
Show file tree

Hide file tree

Showing 4 changed files with 92 additions and 15 deletions.
diff --git a/apis/delivery/v1alpha1/constants.go b/apis/delivery/v1alpha1/constants.go
@@ -0,0 +1,6 @@
+package v1alpha1
+
+const (
+	// StatusCheckName defines the name of the check a PullRequest will have.
+	StatusCheckName = "mpas/validation-check"
+)
diff --git a/pkg/providers/gitea/gitea.go b/pkg/providers/gitea/gitea.go
@@ -12,13 +12,13 @@ import (
 	"fmt"
 
 	"code.gitea.io/sdk/gitea"
-	v1 "k8s.io/api/core/v1"
-	"k8s.io/apimachinery/pkg/types"
-	"sigs.k8s.io/controller-runtime/pkg/client"
-
 	deliveryv1alpha1 "github.com/open-component-model/git-controller/apis/delivery/v1alpha1"
 	mpasv1alpha1 "github.com/open-component-model/git-controller/apis/mpas/v1alpha1"
 	"github.com/open-component-model/git-controller/pkg/providers"
+	v1 "k8s.io/api/core/v1"
+	"k8s.io/apimachinery/pkg/types"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+	"sigs.k8s.io/controller-runtime/pkg/log"
 )
 
 const (
@@ -33,7 +33,7 @@ type Client struct {
 	next   providers.Provider
 }
 
-// NewClient creates a new GitHub client.
+// NewClient creates a new Gitea client.
 func NewClient(client client.Client, next providers.Provider) *Client {
 	return &Client{
 		client: client,
@@ -170,7 +170,7 @@ func (c *Client) CreatePullRequest(ctx context.Context, branch string, sync deli
 		domain = repository.Spec.Domain
 	}
 
-	client, err := gitea.NewClient(domain, gitea.SetToken(string(token)))
+	gclient, err := gitea.NewClient(domain, gitea.SetToken(string(token)))
 	if err != nil {
 		return -1, fmt.Errorf("failed to create gitea client: %w", err)
 	}
@@ -193,7 +193,7 @@ func (c *Client) CreatePullRequest(ctx context.Context, branch string, sync deli
 		description = sync.Spec.PullRequestTemplate.Description
 	}
 
-	pr, _, err := client.CreatePullRequest(repository.Spec.Owner, repository.GetName(), gitea.CreatePullRequestOption{
+	pr, _, err := gclient.CreatePullRequest(repository.Spec.Owner, repository.GetName(), gitea.CreatePullRequestOption{
 		Head:  branch,
 		Base:  base,
 		Title: title,
@@ -206,6 +206,62 @@ func (c *Client) CreatePullRequest(ctx context.Context, branch string, sync deli
 	return int(pr.ID), nil
 }
 
-func (c *Client) CreateBranchProtection(ctx context.Context, obj mpasv1alpha1.Repository) error {
-	return providers.NotSupportedError
+func (c *Client) CreateBranchProtection(ctx context.Context, repository mpasv1alpha1.Repository) error {
+	logger := log.FromContext(ctx)
+
+	logger.Info("using gitea provider to set up branch protection")
+
+	if repository.Spec.Provider != providerType {
+		if c.next == nil {
+			return fmt.Errorf("can't handle provider type '%s' and no next provider is configured", repository.Spec.Provider)
+		}
+
+		return c.next.CreateBranchProtection(ctx, repository)
+	}
+
+    //TODO: use safe auth strategy post MVP
+	secret := &v1.Secret{}
+	if err := c.client.Get(ctx, types.NamespacedName{
+		Name:      repository.Spec.Credentials.SecretRef.Name,
+		Namespace: repository.Namespace,
+	}, secret); err != nil {
+		return fmt.Errorf("failed to get secret: %w", err)
+	}
+
+	token, ok := secret.Data[tokenKey]
+	if !ok {
+		return fmt.Errorf("token '%s' not found in secret", tokenKey)
+	}
+
+	logger.Info("got secret")
+
+	domain := defaultDomain
+	if repository.Spec.Domain != "" {
+		domain = repository.Spec.Domain
+	}
+
+	logger.Info("default domain set", "domain", domain)
+
+	gclient, err := gitea.NewClient(domain, gitea.SetToken(string(token)))
+	if err != nil {
+		return fmt.Errorf("failed to create gitea client: %w", err)
+	}
+
+	defaultBranch := "main"
+	if repository.Spec.DefaultBranch != "" {
+		defaultBranch = repository.Spec.DefaultBranch
+	}
+
+	logger.Info("using default branch", "branch", defaultBranch)
+
+	if _, _, err := gclient.CreateBranchProtection(repository.Spec.Owner, repository.Name, gitea.CreateBranchProtectionOption{
+		BranchName:          defaultBranch,
+		EnablePush:          true,
+		EnableStatusCheck:   true,
+		StatusCheckContexts: []string{deliveryv1alpha1.StatusCheckName},
+	}); err != nil {
+		return fmt.Errorf("failed to create branch protection: %w", err)
+	}
+
+	return nil
 }
diff --git a/pkg/providers/github/github.go b/pkg/providers/github/github.go
@@ -23,10 +23,9 @@ import (
 )
 
 const (
-	tokenKey        = "password"
-	providerType    = "github"
-	defaultDomain   = github.DefaultDomain
-	statusCheckName = "mpas/validation-check"
+	tokenKey      = "password"
+	providerType  = "github"
+	defaultDomain = github.DefaultDomain
 )
 
 // Client github.
@@ -77,6 +76,14 @@ func (c *Client) CreateRepository(ctx context.Context, obj mpasv1alpha1.Reposito
 }
 
 func (c *Client) CreateBranchProtection(ctx context.Context, obj mpasv1alpha1.Repository) error {
+	if obj.Spec.Provider != providerType {
+		if c.next == nil {
+			return fmt.Errorf("can't handle provider type '%s' and no next provider is configured", obj.Spec.Provider)
+		}
+
+		return c.next.CreateBranchProtection(ctx, obj)
+	}
+
 	token, err := c.retrieveAccessToken(ctx, obj)
 	if err != nil {
 		return fmt.Errorf("failed to retrieve token: %w", err)
@@ -91,7 +98,7 @@ func (c *Client) CreateBranchProtection(ctx context.Context, obj mpasv1alpha1.Re
 			Strict: true,
 			Checks: []*ggithub.RequiredStatusCheck{
 				{
-					Context: statusCheckName,
+					Context: deliveryv1alpha1.StatusCheckName,
 				},
 			},
 		},
@@ -193,7 +200,7 @@ func (c *Client) createCheckRun(ctx context.Context, repository mpasv1alpha1.Rep
 	_, _, err = g.Repositories.CreateStatus(ctx, repository.Spec.Owner, repository.Name, *pr.Head.SHA, &ggithub.RepoStatus{
 		State:       ggithub.String("pending"),
 		Description: ggithub.String("MPAS Validation Check"),
-		Context:     ggithub.String(statusCheckName),
+		Context:     ggithub.String(deliveryv1alpha1.StatusCheckName),
 	})
 
 	if err != nil {

diff --git a/pkg/providers/gitlab/gitlab.go b/pkg/providers/gitlab/gitlab.go
@@ -126,5 +126,13 @@ func (c *Client) CreatePullRequest(ctx context.Context, branch string, sync deli
 }
 
 func (c *Client) CreateBranchProtection(ctx context.Context, obj mpasv1alpha1.Repository) error {
+	if obj.Spec.Provider != providerType {
+		if c.next == nil {
+			return fmt.Errorf("can't handle provider type '%s' and no next provider is configured", obj.Spec.Provider)
+		}
+
+		return c.next.CreateBranchProtection(ctx, obj)
+	}
+
 	return providers.NotSupportedError
 }