Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ARM JupyerHub badges to README and example notebook (+ adding header pip-pinstall code blocks) #331

Merged
merged 11 commits into from
Jan 18, 2024

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Jan 17, 2024

No description provided.

@slayoo slayoo requested a review from zdaq12 January 17, 2024 19:12
Copy link

CLANG WARNINGS:

error: no input files [clang-diagnostic-error]
error: no such file or directory: '/github/workspace/files/*.cpp' [clang-diagnostic-error]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]

CPPCHECK WARNINGS:

clang-tidy-report.txt:3:101: error: syntax error [syntaxError]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]
                                                                                                    ^

Copy link

CLANG WARNINGS:

error: no input files [clang-diagnostic-error]
error: no such file or directory: '/github/workspace/files/*.cpp' [clang-diagnostic-error]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]

CPPCHECK WARNINGS:

clang-tidy-report.txt:3:101: error: syntax error [syntaxError]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]
                                                                                                    ^

@slayoo slayoo requested a review from jcurtis2 January 17, 2024 19:42
Copy link

CLANG WARNINGS:

error: no input files [clang-diagnostic-error]
error: no such file or directory: '/github/workspace/files/*.cpp' [clang-diagnostic-error]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]

CPPCHECK WARNINGS:

clang-tidy-report.txt:3:101: error: syntax error [syntaxError]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]
                                                                                                    ^

Copy link
Member

@jcurtis2 jcurtis2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure there is any added value but we could use the url feature to get the user at least partially to the notebook. I don't see how we can do it entirely to the notebook since the path is different for each user (it would be nice if we could somehow get the NBGITPULLER_PARENTPATH variable to get the user home) but this would get them closer (and maybe have it be a bit more obvious where to go?)

https://jupyterhub.arm.gov/hub/user-redirect/git-pull?repo=https%3A//github.com/open-atmos/PyPartMC&branch=main&urlPath=lab%2Ftree%2Fdata%2Fhome

@slayoo
Copy link
Member Author

slayoo commented Jan 17, 2024

The link under the ARM badge in this PR gets the user directly into the PyPartMC dir, no idea how to direct into examples or how to single-click open a notebook (as it is possible on Colab, mybinder or Voila)

@slayoo
Copy link
Member Author

slayoo commented Jan 17, 2024

@jcurtis2 shall we add such badges and header to all notebooks? (and to README?)

@jcurtis2
Copy link
Member

The link under the ARM badge in this PR gets the user directly into the PyPartMC dir, no idea how to direct into examples or how to single-click open a notebook (as it is possible on Colab, mybinder or Voila)

Odd.. it doesn't actually do this for me.

PyPartMC is in /data/home/jcurtis for me but I end up in / initially (then have to traverse to eventually get to PyPartMC).

@slayoo
Copy link
Member Author

slayoo commented Jan 17, 2024

this is how it looks here right after clicking on the badge (with luckily examples being the first entry!):
image

@slayoo
Copy link
Member Author

slayoo commented Jan 17, 2024

after clicking on this badge:
image

@slayoo
Copy link
Member Author

slayoo commented Jan 17, 2024

(just checked in "Private mode" opening a fresh session - same effect - straight into PyPartMC folder)

@jcurtis2
Copy link
Member

Odd. I must have been doing something wrong previously - I get the same as your screenshot now.

Copy link

CLANG WARNINGS:

error: no input files [clang-diagnostic-error]
error: no such file or directory: '/github/workspace/files/*.cpp' [clang-diagnostic-error]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]

CPPCHECK WARNINGS:

README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:3:101: error: syntax error [syntaxError]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]
                                                                                                    ^

@slayoo slayoo changed the title add ARM JupyerHub badge and header code to hello_world notebook add ARM JupyerHub badges to README and example notebook (+ adding header pip-pinstall code blocks) Jan 17, 2024
Copy link

CLANG WARNINGS:

error: no input files [clang-diagnostic-error]
error: no such file or directory: '/github/workspace/files/*.cpp' [clang-diagnostic-error]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]

CPPCHECK WARNINGS:

README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:3:101: error: syntax error [syntaxError]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]
                                                                                                    ^

1 similar comment
Copy link

CLANG WARNINGS:

error: no input files [clang-diagnostic-error]
error: no such file or directory: '/github/workspace/files/*.cpp' [clang-diagnostic-error]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]

CPPCHECK WARNINGS:

README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:3:101: error: syntax error [syntaxError]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]
                                                                                                    ^

Copy link

CLANG WARNINGS:

error: no input files [clang-diagnostic-error]
error: no such file or directory: '/github/workspace/files/*.cpp' [clang-diagnostic-error]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]

CPPCHECK WARNINGS:

README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:3:101: error: syntax error [syntaxError]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]
                                                                                                    ^

Copy link

CLANG WARNINGS:

error: no input files [clang-diagnostic-error]
error: no such file or directory: '/github/workspace/files/*.cpp' [clang-diagnostic-error]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]

CPPCHECK WARNINGS:

README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:3:101: error: syntax error [syntaxError]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]
                                                                                                    ^

1 similar comment
Copy link

CLANG WARNINGS:

error: no input files [clang-diagnostic-error]
error: no such file or directory: '/github/workspace/files/*.cpp' [clang-diagnostic-error]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]

CPPCHECK WARNINGS:

README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:3:101: error: syntax error [syntaxError]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]
                                                                                                    ^

Copy link

CLANG WARNINGS:

error: no input files [clang-diagnostic-error]
error: no such file or directory: '/github/workspace/files/*.cpp' [clang-diagnostic-error]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]

CPPCHECK WARNINGS:

README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:3:101: error: syntax error [syntaxError]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]
                                                                                                    ^

Copy link

CLANG WARNINGS:

error: no input files [clang-diagnostic-error]
error: no such file or directory: '/github/workspace/files/*.cpp' [clang-diagnostic-error]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]

CPPCHECK WARNINGS:

README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:3:101: error: syntax error [syntaxError]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]
                                                                                                    ^

@slayoo
Copy link
Member Author

slayoo commented Jan 18, 2024

@jcurtis2 @zdaq12 Let me merge this "as is", and:

  • we can change the badge URLs if we later find a way to direct ARM JupyterHub to a particular notebook
  • let's test the README and notebook badges, and if all executes OK on ARM machines

In case you have an account with the elevated permission, please also confirm if this work well there as well.
Thanks

@slayoo slayoo merged commit b3e0d83 into main Jan 18, 2024
36 checks passed
@slayoo slayoo deleted the slayoo-patch-1 branch May 29, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants