-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ARM JupyerHub badges to README and example notebook (+ adding header pip-pinstall code blocks) #331
Conversation
CLANG WARNINGS:
CPPCHECK WARNINGS:
|
CLANG WARNINGS:
CPPCHECK WARNINGS:
|
CLANG WARNINGS:
CPPCHECK WARNINGS:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure there is any added value but we could use the url feature to get the user at least partially to the notebook. I don't see how we can do it entirely to the notebook since the path is different for each user (it would be nice if we could somehow get the NBGITPULLER_PARENTPATH
variable to get the user home) but this would get them closer (and maybe have it be a bit more obvious where to go?)
The link under the ARM badge in this PR gets the user directly into the |
@jcurtis2 shall we add such badges and header to all notebooks? (and to README?) |
Odd.. it doesn't actually do this for me. PyPartMC is in |
(just checked in "Private mode" opening a fresh session - same effect - straight into PyPartMC folder) |
Odd. I must have been doing something wrong previously - I get the same as your screenshot now. |
CLANG WARNINGS:
CPPCHECK WARNINGS:
|
CLANG WARNINGS:
CPPCHECK WARNINGS:
|
1 similar comment
CLANG WARNINGS:
CPPCHECK WARNINGS:
|
CLANG WARNINGS:
CPPCHECK WARNINGS:
|
CLANG WARNINGS:
CPPCHECK WARNINGS:
|
1 similar comment
CLANG WARNINGS:
CPPCHECK WARNINGS:
|
CLANG WARNINGS:
CPPCHECK WARNINGS:
|
CLANG WARNINGS:
CPPCHECK WARNINGS:
|
@jcurtis2 @zdaq12 Let me merge this "as is", and:
In case you have an account with the elevated permission, please also confirm if this work well there as well. |
No description provided.