Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid bogus naming of the macos wheels as universal2 despite intel-only #309

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Nov 26, 2023

No description provided.

@slayoo
Copy link
Member Author

slayoo commented Nov 26, 2023

Nope, didn't help, still the following files are produced:

dist/PyPartMC-0.9.0.post4-cp310-cp310-macosx_12_0_x86_64.whl
dist/PyPartMC-0.9.0.post4-cp311-cp311-macosx_12_0_universal2.whl
dist/PyPartMC-0.9.0.post4-cp37-cp37m-macosx_12_0_x86_64.whl
dist/PyPartMC-0.9.0.post4-cp38-cp38-macosx_12_0_x86_64.whl
dist/PyPartMC-0.9.0.post4-cp39-cp39-macosx_12_0_x86_64.whl

?

@slayoo slayoo marked this pull request as draft November 26, 2023 02:32
@slayoo slayoo changed the title try avoiding bogus naming of the macos wheels as universal2 despite intel-only avoid bogus naming of the macos wheels as universal2 despite intel-only Dec 2, 2023
@slayoo slayoo marked this pull request as ready for review December 3, 2023 00:13
@slayoo slayoo requested a review from zdaq12 December 3, 2023 00:13
@slayoo slayoo marked this pull request as draft December 3, 2023 00:25
@slayoo
Copy link
Member Author

slayoo commented Dec 3, 2023

@zdaq12 this one addresses the issue of publishing macOS binary packages labelled as universal2 (i.e., with binaries for both Intel and ARM CPUs in single file) but containing actually only x86_64 binaries inside.

I haven't found the cause of this issue (which is present only for Python 3.11), so this PR proposes to manually "fix" these files before uploading by renaming the .whl files and altering the metadata inside (the WHEEL file).

For the record, the wheel format is described here: https://packaging.python.org/en/latest/specifications/binary-distribution-format/#file-format

It is tricky to test it before merging. After merging, there should be no more universal2 files uploaded to test.pypi.org for a given release (and to the main pypi.org after the next release).

@slayoo slayoo added this to the v1.0.0 milestone Dec 3, 2023
@slayoo slayoo closed this Dec 3, 2023
@slayoo slayoo reopened this Dec 3, 2023
@slayoo slayoo marked this pull request as ready for review December 3, 2023 04:12
@zdaq12 zdaq12 added this pull request to the merge queue Dec 5, 2023
Merged via the queue into open-atmos:main with commit 938be42 Dec 5, 2023
57 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stop labelling PyPI macos wheels as universal if the contents are for intel only
2 participants