Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

threads + MPI test cases (currently n_threads=1 in test_2d.py) #35

Closed
slayoo opened this issue Mar 27, 2023 · 4 comments
Closed

threads + MPI test cases (currently n_threads=1 in test_2d.py) #35

slayoo opened this issue Mar 27, 2023 · 4 comments

Comments

@slayoo
Copy link
Member

slayoo commented Mar 27, 2023

No description provided.

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions github-actions bot closed this as completed Aug 7, 2023
@slayoo slayoo reopened this Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Stale issue message

@slayoo slayoo reopened this Nov 27, 2023
@github-actions GitHub Actions
Copy link

Stale issue message

@github-actions github-actions bot closed this as completed Feb 2, 2024
@slayoo slayoo reopened this Feb 7, 2024
Delcior added a commit to Delcior/PySuperDropletLES that referenced this issue Mar 7, 2024
@Delcior
allocate buffer for every thread. Closes open-atmos#35
8a4d647
github-merge-queue bot pushed a commit that referenced this issue Mar 22, 2024
@Delcior @slayoo
add support for threading and for user-specified MPI dimension. Closes …
3f07a87 
…#35 (#98)

* mpi: outer, threads:2

* add TODO ids

* add TODO label (3D support)

* skipping multi-threading tests if JIT disabled

* add pylint-disable comment

* print number of cores on workers

* log info about supported plotting options

* debug: print num_threads per worker

* debug: omit pylint

* debug: omit pylint

* hardcore threads

* fix issue number

* mpi_dim as scenarion ctor argument; new test for mpi_indices; more readable code around send/recv tags for threading

* pylint fixes

* pylint fixes ++

* pylint disable too-many-args for whole file

* check thread number every time

* increase workflow timeout

* check if the 3rd-order-terms issue indeed is present?

* indeed 3rd-order terms cause problems with mpi_dim=INNER :(

* increase timeout to 120min

* remove 4th worker from the test

* increase timeout to 60min

* updates to README to reflect threading support changes

* removing debug leftover

---------

Co-authored-by: Sylwester Arabas <[email protected]>
Co-authored-by: Sylwester Arabas <[email protected]>
@Delcior Delcior closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slayoo @Delcior