Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax poison version to prevent version conflicts in library usage #322

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

seantanly
Copy link
Contributor

The dep poison hasn't been updated for a long time, sitting at version 4.0.1. Many libraries have already moved to version 4.0 or off it.

The change adds support for ~> 4.0, thus removing version conflicts that arise due to the current requirement of "~> 3.1", even though it's marked as optional.

@moxley moxley merged commit b8be7d8 into open-api-spex:master Jan 31, 2021
@moxley
Copy link
Contributor

moxley commented Jan 31, 2021

Thanks @seantanly !!!

@mbuhot
Copy link
Collaborator

mbuhot commented Jan 31, 2021

TBH I think users of Poison 4.x should be made to use override: true in their mix.exs file.
It is incompatible with several libraries, due to: devinus/poison#172

@seantanly
Copy link
Contributor Author

TBH I think users of Poison 4.x should be made to use override: true in their mix.exs file.
It is incompatible with several libraries, due to: devinus/poison#172

I have tried that and even with the override above open-api-spex, the conflicts still occur, unfortunately.

{:poison, "~> 4.0", override: true},
{:open_api_spex, "~> 3.10"}

Unless open_api_spex doesn't work with Poison 4.x (tests passed), it should be fine additionally specifying the Poison 4.x support.

@mbuhot
Copy link
Collaborator

mbuhot commented Feb 1, 2021

I have tried that and even with the override above open-api-spex, the conflicts still occur, unfortunately.

Sounds like a bug.

Unless open_api_spex doesn't work with Poison 4.x (tests passed), it should be fine additionally specifying the Poison 4.x support.

Yeah it's not a problem for open_api_spex.

Out of curiosity, is there a library that is only compatible with Poison 4.0?
After a quick search on Hex and Github all I could find are libraries like Ecto and Phoenix that have removed it as a dependency altogether, or older libraries that depend on version 3.

@seantanly
Copy link
Contributor Author

Out of curiosity, is there a library that is only compatible with Poison 4.0?
After a quick search on Hex and Github all I could find are libraries like Ecto and Phoenix that have removed it as a dependency altogether, or older libraries that depend on version 3.

elastix which unfortunately did not release a newer version though that is fixed on master.
werbitzky/elastix@05ec79f#diff-dfa6f4ed74c90e5d4fda283d547d366586e690387289bcfd473e3fa5f9ace308R43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants