LERC_jll 3 to 4, downgrade DimensionalData to 0.27.9, Julia Pkg update #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlowhite
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
=======================================
Coverage 49.36% 49.36%
=======================================
Files 70 70
Lines 4734 4734
=======================================
Hits 2337 2337
Misses 2397 2397 ☔ View full report in Codecov by Sentry. |
ConnectedSystems
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GDAL error related to LERC@4 in Linux is fixed:
JuliaGeo/GDAL.jl#179
JuliaPackaging/Yggdrasil#9588
Ran
updatein both Julia 1.11 and 1.10Some minor updates to other packages, see manifest diff.
Downgraded DimensionalData and GeoMakie (compat) to fix Unit Tests.
Changed Unit Tests workflow to run on PRs that modify manifest to catch these issues in the future.
DimensionalData Error
#881
This PR's Unit Tests and the previous
mainrun failed.https://github.com/open-AIMS/ADRIA.jl/actions/runs/11247637592/job/31271460535#step:6:1130
Worried that DimensionalData update from 0.27 to 0.28 in PR #878 is a problem. Verifying...
GeoMakie 0.7 Error
#882