Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC - AI Avatar Animation Design #59

Merged
merged 33 commits into from
Sep 9, 2024
Merged

Conversation

ctao456
Copy link
Contributor

@ctao456 ctao456 commented Aug 2, 2024

Add RFC for AI avatar animation project

opea-project/GenAIComps#400
opea-project/GenAIExamples#523

@ctao456 ctao456 changed the title [RFC] AI Avatar Animation Design [RFC] AI Avatar Animation Design [WIP] Aug 2, 2024
@ctao456 ctao456 changed the title [RFC] AI Avatar Animation Design [WIP] [WIP] RFC - AI Avatar Animation Design Aug 2, 2024
Copy link
Contributor

@louie-tsai louie-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great works. put some comments in PR.

community/rfcs/24-08-02-OPEA-AIAvatarChatbot.md Outdated Show resolved Hide resolved
community/rfcs/24-08-02-OPEA-AIAvatarChatbot.md Outdated Show resolved Hide resolved
community/rfcs/24-08-02-OPEA-AIAvatarChatbot.md Outdated Show resolved Hide resolved
community/rfcs/24-08-02-OPEA-AIAvatarChatbot.md Outdated Show resolved Hide resolved
community/rfcs/24-08-02-OPEA-AIAvatarChatbot.md Outdated Show resolved Hide resolved
community/rfcs/24-08-02-OPEA-AIAvatarChatbot.md Outdated Show resolved Hide resolved
community/rfcs/24-08-02-OPEA-AIAvatarChatbot.md Outdated Show resolved Hide resolved
community/rfcs/24-08-02-OPEA-AIAvatarChatbot.md Outdated Show resolved Hide resolved
community/rfcs/24-08-02-OPEA-AIAvatarChatbot.md Outdated Show resolved Hide resolved
ctao456 added 15 commits August 12, 2024 22:35
Signed-off-by: Chun Tao <[email protected]>
Signed-off-by: Chun Tao <[email protected]>
Signed-off-by: Chun Tao <[email protected]>
Signed-off-by: Chun Tao <[email protected]>
Signed-off-by: Chun Tao <[email protected]>
Signed-off-by: Chun Tao <[email protected]>
Signed-off-by: Chun Tao <[email protected]>
Signed-off-by: Chun Tao <[email protected]>
Signed-off-by: Chun Tao <[email protected]>
Signed-off-by: Chun Tao <[email protected]>
Signed-off-by: Chun Tao <[email protected]>
Signed-off-by: Chun Tao <[email protected]>
Signed-off-by: Chun Tao <[email protected]>
@ctao456 ctao456 changed the title [WIP] RFC - AI Avatar Animation Design RFC - AI Avatar Animation Design Aug 22, 2024
Copy link
Contributor

@louie-tsai louie-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a title suggested fix

community/rfcs/24-08-02-OPEA-AIAvatarChatbot.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you didn't do a "git commit -s" so your PR is missing the required Signed-off-by: line in the commit message :(

ctao456 and others added 2 commits September 9, 2024 14:38
Co-authored-by: David Kinder <[email protected]>
Signed-off-by: srinarayan-srikanthan <[email protected]>
* use improved globbing pattern to collect markdown docs in the repos
* add GenAIInfra/proxy docs to deploy section (was in opea-project#96)

Signed-off-by: David B. Kinder <[email protected]>
Signed-off-by: srinarayan-srikanthan <[email protected]>
@ctao456
Copy link
Contributor Author

ctao456 commented Sep 9, 2024

Looks like you didn't do a "git commit -s" so your PR is missing the required Signed-off-by: line in the commit message :(

Thank you. That was true. I was using the web interface to commit. Should never use it. I fixed it by rebasing to HEAD~2 and commited with sign-off, then force pushing.

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkbhanda mkbhanda merged commit a1c8e82 into opea-project:main Sep 9, 2024
1 check passed
tomlenth pushed a commit that referenced this pull request Sep 17, 2024
* rfc draft

Signed-off-by: Chun Tao <[email protected]>

* rfc pics

Signed-off-by: Chun Tao <[email protected]>

* update

Signed-off-by: Chun Tao <[email protected]>

* revert unncecessary changes

Signed-off-by: Chun Tao <[email protected]>

* revert unnecessary changes

Signed-off-by: Chun Tao <[email protected]>

* Update 24-08-02-OPEA-AIAvatarChatbot.md

Signed-off-by: Chun Tao <[email protected]>

* update

Signed-off-by: Chun Tao <[email protected]>

* update

Signed-off-by: Chun Tao <[email protected]>

* updates to include mjpegs

Signed-off-by: Chun Tao <[email protected]>

* switch to mpg files

Signed-off-by: Chun Tao <[email protected]>

* switched to gif

Signed-off-by: Chun Tao <[email protected]>

* update

Signed-off-by: Chun Tao <[email protected]>

* update flowcharts

Signed-off-by: Chun Tao <[email protected]>

* update flowcharts

Signed-off-by: Chun Tao <[email protected]>

* updated mermaid graph with larger font

Signed-off-by: Chun Tao <[email protected]>

* updated flowchart

Signed-off-by: Chun Tao <[email protected]>

* update flowchart

Signed-off-by: Chun Tao <[email protected]>

* update

Signed-off-by: Chun Tao <[email protected]>

* update

Signed-off-by: Chun Tao <[email protected]>

* update rfc

Signed-off-by: Chun Tao <[email protected]>

* delete avatar 5

Signed-off-by: Chun Tao <[email protected]>

* Update avatar flowchart

Signed-off-by: Chun Tao <[email protected]>

* update

Signed-off-by: Chun Tao <[email protected]>

* Update community/rfcs/24-08-02-OPEA-AIAvatarChatbot.md

Co-authored-by: David Kinder <[email protected]>
Signed-off-by: srinarayan-srikanthan <[email protected]>

* doc: improved use of globbing in toctree (#99)

* use improved globbing pattern to collect markdown docs in the repos
* add GenAIInfra/proxy docs to deploy section (was in #96)

Signed-off-by: David B. Kinder <[email protected]>
Signed-off-by: srinarayan-srikanthan <[email protected]>

---------

Signed-off-by: Chun Tao <[email protected]>
Signed-off-by: srinarayan-srikanthan <[email protected]>
Signed-off-by: David B. Kinder <[email protected]>
Co-authored-by: David Kinder <[email protected]>
Signed-off-by: Tom Lenth <[email protected]>
Comment on lines +192 to +193
<!-- [AI Avatar Chatbot Demo on Intel® Gaudi® 2, image input](https://intel.sharepoint.com/:v:/s/mlconsultingandsupport/EZa7vjON10ZCpMvE7U-SPMwBRXbVHqe1Ybsa-fmnXayNUA?e=f6FPsl)
[AI Avatar Chatbot Demo on Intel® Gaudi® 2, video input](https://intel.sharepoint.com/:v:/s/mlconsultingandsupport/ESMIcBseFTdIuqkoB7TZy6ABfwR9CkfV49TvTa1X_Jihkg?e=zMH7O7) -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctao456 We shouldn't have such an URL in our documentation (it's not accessible to the community). If that video is important, it should be put in a public location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants