Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OPEA API spec to 1.0 version #167

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Update OPEA API spec to 1.0 version #167

merged 1 commit into from
Oct 18, 2024

Conversation

ftian1
Copy link
Collaborator

@ftian1 ftian1 commented Sep 20, 2024

No description provided.

@ftian1 ftian1 requested a review from kevinintel September 20, 2024 06:02
@ftian1
Copy link
Collaborator Author

ftian1 commented Sep 20, 2024

@dbkinder pls be aware of this change which may impact the content in opea.github.io

dbkinder
dbkinder reviewed Sep 22, 2024
View reviewed changes
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed the version number but there's no change to the contents. There are technical errors in the content that should be fixed.

@chickenrae
Copy link
Member

Have @dbkinder 's comments been addressed?

@mkbhanda
Copy link
Collaborator

mkbhanda commented Oct 8, 2024

There were no additional commits since @dbkinder review and I do not know what the technical issues were. The two other files are binaries. @ftian1 would you please shed light or do we need to trouble @dbkinder in his retirement?

@ftian1
Copy link
Collaborator Author

ftian1 commented Oct 9, 2024 •
edited
Loading

@mkbhanda @chickenrae let me confirm with @dbkinder. Anyway, those API spec files will be removed at 1.1 release by swagger json file. we can fix it at that time.

yinghu5
yinghu5 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@yinghu5 yinghu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yinghu5 yinghu5 merged commit 86454b7 into opea-project:main Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkinder dbkinder dbkinder left review comments

@kevinintel kevinintel kevinintel approved these changes

@yinghu5 yinghu5 yinghu5 approved these changes

@chensuyue chensuyue Awaiting requested review from chensuyue chensuyue is a code owner

@mkbhanda mkbhanda Awaiting requested review from mkbhanda mkbhanda is a code owner

@preethivenkatesh preethivenkatesh Awaiting requested review from preethivenkatesh preethivenkatesh is a code owner

@chickenrae chickenrae Awaiting requested review from chickenrae chickenrae is a code owner

@tomlenth tomlenth Awaiting requested review from tomlenth tomlenth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ftian1 @chickenrae @mkbhanda @dbkinder @yinghu5 @kevinintel