helm chart: Add service account support #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2024
|
The failure is not related to this PR, please see issue opea-project/GenAIComps#969 |
poussa
approved these changes
Dec 10, 2024
yongfengdu
approved these changes
Dec 10, 2024
1. Add service account creation support, disabled by default. 2. Add support of sharing the same service account by setting global.sharedSAName, disabled by default. Signed-off-by: Lianhao Lu <[email protected]>
1. Add service account creation support, enabled by default. 2. Add support of sharing the same service account by setting global.sharedSAName, enabled by default. Signed-off-by: Lianhao Lu <[email protected]>
yongfengdu
force-pushed
the
sa_support
branch
from
90b3f4f to
b337287
Compare
|
All CI jobs have passed except for the known issue opea-project/GenAIComps#969 which is not related to this PR. I'll merge this PR first to avoid rerun dozens of CI jobs again. |
mkbhanda
pushed a commit
that referenced
this pull request
Dec 11, 2024
* CI: dump all containers' log for chart test (#627) Signed-off-by: Lianhao Lu <[email protected]> Signed-off-by: kkrishTa <[email protected]> * AKS Deployment for OPEA applications Signed-off-by: kkrishTa <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: kkrishTa <[email protected]> * Reverted changes by pre commit hook. Updated readme as per suggestions Signed-off-by: kkrishTa <[email protected]> * Adding code spell ignore for Azure Kubernetes Service Signed-off-by: kkrishTa <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: kkrishTa <[email protected]> * Adding code spell ignore for AKS and reverting pre commit changes Signed-off-by: kkrishTa <[email protected]> * Updating cluster name to opea as a generic name Signed-off-by: kkrishTa <[email protected]> * helm chart: Add service account support (#624) * helm: Add service account support in common services 1. Add service account creation support, disabled by default. 2. Add support of sharing the same service account by setting global.sharedSAName, disabled by default. Signed-off-by: Lianhao Lu <[email protected]> * helm: Add service account support in e2e charts 1. Add service account creation support, enabled by default. 2. Add support of sharing the same service account by setting global.sharedSAName, enabled by default. Signed-off-by: Lianhao Lu <[email protected]> --------- Signed-off-by: Lianhao Lu <[email protected]> Signed-off-by: kkrishTa <[email protected]> * README: add links to terraform docs (#633) * README: add links to terraform docs Signed-off-by: Sakari Poussa <[email protected]> * README: fix broken links Signed-off-by: Sakari Poussa <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Sakari Poussa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: kkrishTa <[email protected]> * Adding link to the Azure terraform readme to opea documentation Signed-off-by: kkrishTa <[email protected]> * Corrected md file link Signed-off-by: kkrishTa <[email protected]> * Updated relative links Signed-off-by: kkrishTa <[email protected]> --------- Signed-off-by: Lianhao Lu <[email protected]> Signed-off-by: kkrishTa <[email protected]> Signed-off-by: Sakari Poussa <[email protected]> Co-authored-by: Lianhao Lu <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sakari Poussa <[email protected]>
|
@poussa Service account name is not prefixed with Helm chart release name, like is the case with all the other created k8s objects. Is that a problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add service account support disabled by default for all common charts, enabled by default for all e2e charts.
Add support of sharing the same service account by setting
global.sharedSAName, disabled by default for all common charts, enabled by default for all e2e charts.Issues
Fixes #532.
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a.
Tests
Describe the tests that you ran to verify your changes.