-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[helm] makefile target for ghcr.io hosting #514
Conversation
Signed-off-by: Sakari Poussa <[email protected]>
Dolpher had the experience of publish helm charts to repo, so added him as the reviewer. And we're planning to move all the helm charts from here to GenAIExamples and GenAIComps repos respectively in v1.2 release cycle. |
Who has access to publish? @hshen14 ? @yongfengdu . Please provide @poussa |
Current released charts are here, https://github.com/opea-project/GenAIInfra/tree/charts-release, and was generated by this script: |
|
||
.PHONY: helm-push | ||
helm-push: | ||
@for chart in $$(find $(CHARTS_DIR) -maxdepth 2 -type f -name "Chart.yaml" | cut -d "/" -f 3); do \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"-maxdepth 2" only cover the top level examples, we should also release the helm charts for components, which are in the helm-charts/common directory.
https://github.com/opea-project/GenAIInfra/tree/charts-release
@poussa Just talked with @lianhao and found more gaps with the version management.
To use the Makefile version, all helm-chart version are modified on the fly, this leaves the docker images version unchanged, and the dependency in Chart.yaml is not changed accordingly. Before the above issues discussed and resolved, I think we still need to do the release via gihub actions instead of just simple "make helm-push" |
As we decide to use GH workflow to handle the release, this PR will be closed after #570 merged. |
Description
Push Helm charts to opea-project ghcr.io registry
ghcr.io/opea-project/charts/<chart-name>
Issues
#342
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
Tested manually. Pushes charts properly.