Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] makefile target for ghcr.io hosting #514

Closed
wants to merge 1 commit into from

Conversation

poussa
Copy link
Collaborator

@poussa poussa commented Oct 30, 2024

Description

Push Helm charts to opea-project ghcr.io registry ghcr.io/opea-project/charts/<chart-name>

Issues

#342

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

None

Tests

Tested manually. Pushes charts properly.

@poussa poussa marked this pull request as draft October 30, 2024 12:50
@lianhao lianhao requested review from yongfengdu and removed request for daisy-ycguo October 31, 2024 01:46
@lianhao
Copy link
Collaborator

lianhao commented Oct 31, 2024

Dolpher had the experience of publish helm charts to repo, so added him as the reviewer. And we're planning to move all the helm charts from here to GenAIExamples and GenAIComps repos respectively in v1.2 release cycle.

@mkbhanda
Copy link
Collaborator

Who has access to publish? @hshen14 ? @yongfengdu . Please provide @poussa

@yongfengdu
Copy link
Collaborator

Current released charts are here, https://github.com/opea-project/GenAIInfra/tree/charts-release, and was generated by this script:
https://github.com/opea-project/GenAIInfra/blob/charts-release/update_chart_repo.sh
To avoid version confusion, I suggest we just push the current one from charts-release to ghcr.io instead of "helm package" again.
for file in *1.0.0.tgz; do helm push $file oci://$(RELEASE_REGISTRY)/charts; done
We can enhance the current script and setup CIs for automatic release after the helm-chart directory move done.

@poussa poussa changed the title helm: makefile target for ghcr.io hosting [helm] makefile target for ghcr.io hosting Nov 8, 2024
@ftian1 ftian1 added the V1.1 OPEA 1.1 RELEASE TAG label Nov 8, 2024
@poussa poussa marked this pull request as ready for review November 8, 2024 11:34
@poussa poussa added this to the v1.1 milestone Nov 8, 2024

.PHONY: helm-push
helm-push:
@for chart in $$(find $(CHARTS_DIR) -maxdepth 2 -type f -name "Chart.yaml" | cut -d "/" -f 3); do \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"-maxdepth 2" only cover the top level examples, we should also release the helm charts for components, which are in the helm-charts/common directory.
https://github.com/opea-project/GenAIInfra/tree/charts-release

@yongfengdu
Copy link
Collaborator

yongfengdu commented Nov 11, 2024

@poussa Just talked with @lianhao and found more gaps with the version management.
Currenlty for a release, we'll modify versions in this job:
https://github.com/opea-project/GenAIInfra/blob/main/.github/workflows/manual-freeze-tag.yaml

  1. Docker image version - change from latest to release version(v1.1)
    2). Helm chart version upgrade from 1.0.0 to 1.1.0, this include
    a. all components' version upgraded to 1.1.0
    b. Chart.yaml dependency changed to 1.1.0

To use the Makefile version, all helm-chart version are modified on the fly, this leaves the docker images version unchanged, and the dependency in Chart.yaml is not changed accordingly.

Before the above issues discussed and resolved, I think we still need to do the release via gihub actions instead of just simple "make helm-push"

@yongfengdu
Copy link
Collaborator

As we decide to use GH workflow to handle the release, this PR will be closed after #570 merged.

@chensuyue chensuyue closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V1.1 OPEA 1.1 RELEASE TAG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants