GMC: add UT for reconcile filters #383
Conversation
Signed-off-by: KfreeZ <[email protected]>
Signed-off-by: KfreeZ <[email protected]>
KfreeZ
requested review from
irisdingbj,
zhlsunshine and
mkbhanda
and removed request for
irisdingbj and
zhlsunshine
Signed-off-by: KfreeZ <[email protected]>
Signed-off-by: KfreeZ <[email protected]>
…currate sometimes when terninating pod is not cleared but counted Signed-off-by: KfreeZ <[email protected]>
| @@ -137,7 +137,7 @@ function validate_audioqa() { | |||
| pods_count=$(kubectl get pods -n $AUDIOQA_NAMESPACE -o jsonpath='{.items[*].metadata.name}' | wc -w) | |||
| # expected_ready_pods, expected_external_pods, expected_total_pods | |||
| # pods_count-1 is to exclude the client pod in this namespace | |||
| check_gmc_status $AUDIOQA_NAMESPACE 'audioqa' $((pods_count-1)) 0 7 | |||
There was a problem hiding this comment.
Hi @KfreeZ, why do you use precise number instead pods_count ?
There was a problem hiding this comment.
hi @zhlsunshine because the pod count is not accurate sometimes when terminating pod is not cleared but counted
There was a problem hiding this comment.
Okay, I through that it should be okay after calling wait_until_all_pod_ready, if yes, could we just fix the bug for this function?
There was a problem hiding this comment.
the latest wait_until_all_pod_ready has excluded the "Terminating" pods, so there is possibility that the pods are still existing as "Terminating" pods after wait_until_all_pod_ready. Yes I can also count the pods by excluding the "Terminating" pods, but for these test case, the ready counts and total counts are fixed numbers, for chatqa for instances, after a deploy, "8/0/8" is exactly we expected.
There was a problem hiding this comment.
okay, then let's exclude the Terminating pods when calculating the pods_count.
Signed-off-by: KfreeZ <[email protected]>
Signed-off-by: KfreeZ <[email protected]>
|
Do we have explanation of this CI test failure: https://github.com/opea-project/GenAIInfra/actions/runs/10697764146/job/29655792762 |
Signed-off-by: KfreeZ <[email protected]>
Signed-off-by: KfreeZ <[email protected]>
Signed-off-by: KfreeZ <[email protected]>
* fix a badcommit in #383 Signed-off-by: KfreeZ <[email protected]> * fix a badcommit in #383 Signed-off-by: KfreeZ <[email protected]> * fix a badcommit in #383 Signed-off-by: KfreeZ <[email protected]> --------- Signed-off-by: KfreeZ <[email protected]>
* add UT for reconcile filters Signed-off-by: KfreeZ <[email protected]> * remove useless code Signed-off-by: KfreeZ <[email protected]> * update tests Signed-off-by: KfreeZ <[email protected]> * debug CI/CD failed Signed-off-by: KfreeZ <[email protected]> * skip use pod_count in e2e's check_gmc_status, the pod_count is not acurrate sometimes when terninating pod is not cleared but counted Signed-off-by: KfreeZ <[email protected]> * better than hardcode Signed-off-by: KfreeZ <[email protected]> * count the pods right Signed-off-by: KfreeZ <[email protected]> --------- Signed-off-by: KfreeZ <[email protected]>
* fix a badcommit in opea-project#383 Signed-off-by: KfreeZ <[email protected]> * fix a badcommit in opea-project#383 Signed-off-by: KfreeZ <[email protected]> * fix a badcommit in opea-project#383 Signed-off-by: KfreeZ <[email protected]> --------- Signed-off-by: KfreeZ <[email protected]>
Description
Issues
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a.Tests
CI/CD covers the regression tests
controller coverage increased
ok github.com/opea-project/GenAIInfra/microservices-connector/internal/controller 22.452s coverage: 78.2% of statements