helm-chart/common: Add logging config for service components #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianhao
requested changes
Sep 2, 2024
bjzhjing
force-pushed
the
add-logging-config-for-debug
branch
2 times, most recently
from
70bb238 to
b6ec8f9
Compare
lianhao
requested changes
Sep 3, 2024
| @@ -20,3 +20,4 @@ data: | |||
| {{- else }} | |||
| no_proxy: {{ .Values.global.no_proxy | quote }} | |||
| {{- end }} | |||
| LOGFLAG: {{ .Values.LOGFLAG | quote }} | |||
There was a problem hiding this comment.
On second thought, based on the current python code logic1 and logic2, whenever we set the LOGFLAG env as a non-empty string, it will be treated as boolean True.
So we need to change the template accordingly.
There was a problem hiding this comment.
Update each values.yaml file to address the issue, please help take a look.
Logging is added in GenAIComps to print input/output, add it here for components debugging. Signed-off-by: Cathy Zhang <[email protected]>
bjzhjing
force-pushed
the
add-logging-config-for-debug
branch
from
b6ec8f9 to
e221eb9
Compare
lianhao
approved these changes
Sep 4, 2024
yongfengdu
approved these changes
Sep 4, 2024
Yugar-1
pushed a commit
to Yugar-1/GenAIInfra
that referenced
this pull request
Sep 5, 2024
…oject#375) Logging is added in GenAIComps to print input/output, add it here for components debugging. Signed-off-by: Cathy Zhang <[email protected]>
|
Fixed issue #370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging is added in GenAIComps to print input/output, add it here for components debugging.