Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ut #350

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Enhance ut #350

merged 4 commits into from
Aug 26, 2024

Conversation

KfreeZ
Copy link
Collaborator

@KfreeZ KfreeZ commented Aug 26, 2024

Description

Enhance UT, add status update and remove step

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

n/a.

Tests

CI/CD will cover

@lianhao
Copy link
Collaborator

lianhao commented Aug 26, 2024

Seems Makefile is referencing these files, need to change that accordingly

@KfreeZ
Copy link
Collaborator Author

KfreeZ commented Aug 26, 2024

Seems Makefile is referencing these files, need to change that accordingly

@lianhao thanks for point this out, this is supposed to be fixed and cleaned up in #346 , this change in this PR is unexpected due to git branch mess, I will undo it.

Signed-off-by: KfreeZ <[email protected]>
@KfreeZ KfreeZ requested a review from irisdingbj August 26, 2024 10:13
@irisdingbj irisdingbj merged commit 96cd929 into opea-project:main Aug 26, 2024
7 checks passed
@KfreeZ KfreeZ deleted the enhanceUt branch August 30, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants