Validating webhook implementation #274
Conversation
ichbinblau
force-pushed
the
webhook
branch
2 times, most recently
from
42e4ad4 to
06d9e81
Compare
Signed-off-by: ichbinblau <[email protected]>
for more information, see https://pre-commit.ci
ichbinblau
force-pushed
the
webhook
branch
2 times, most recently
from
719ff97 to
23db7a3
Compare
Thanks for the review and the help on troubleshooting! |
Signed-off-by: ichbinblau <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: ichbinblau <[email protected]>
Signed-off-by: ichbinblau <[email protected]>
| } | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we add a use case for ENDPOINT?
for example,
- name: Embedding
internalService:
serviceName: embedding-svc
config:
endpoint: /v1/embeddings
TEI_EMBEDDING_ENDPOINT: tei-embedding-svc
in this step, TEI_EMBEDDING_ENDPOINT: tei-embedding-svc means there must be a step with service name "tei-embedding-svc" in this node.
There was a problem hiding this comment.
Agree this is a good validation case
There was a problem hiding this comment.
Sure, I try to implement it if time permits.
|
thanks for contributing @ichbinblau I left a comment but I think it can be added in next PR. |
|
overall LGTM, for e2e, we need add one case, like invalid gmc config has provided and the validaitonwebhook will check and reject the invalid config |
Hi， @irisdingbj where shall I put the e2e test? In the cicd script or in the test/e2e folder based on ginkgo? |
|
Thanks, plz take a look at https://github.com/opea-project/GenAIInfra/tree/main/.github/workflows/scripts/e2e @ichbinblau |
Signed-off-by: ichbinblau <[email protected]>
There was a problem hiding this comment.
@ichbinblau please resolve conflict and we can get the PR in
Signed-off-by: ichbinblau <[email protected]>
ichbinblau
force-pushed
the
webhook
branch
3 times, most recently
from
fd9bd1d to
fbee849
Compare
Signed-off-by: ichbinblau <[email protected]>
Description
The PR implements a validating webhook to GMC which makes the following validations:
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
Unit test: 8096d89
E2E test: ed34944