-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMC: adopt new common/menifests #203
Conversation
Signed-off-by: KfreeZ <[email protected]>
@@ -36,6 +36,7 @@ function copy_manifests() { | |||
# Copy manifest into gmc | |||
mkdir -p $(pwd)/config/manifests | |||
cp $(dirname $(pwd))/manifests/ChatQnA/*.yaml -p $(pwd)/config/manifests/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove coping from ChatQnA after all manifests finalized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that is planned
tmpltFile := getManifestYaml(step) | ||
if tmpltFile == "" { | ||
return errors.New("unexpected target") | ||
// func getManifestYaml(step string) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KfreeZ can these code lines be removed if they are not used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I'm on it
microservices-connector/internal/controller/gmconnector_controller.go
Outdated
Show resolved
Hide resolved
deployment.Spec.Template.Spec.Containers[i].Env = append( | ||
deployment.Spec.Template.Spec.Containers[i].Env, | ||
newEnvVars...) | ||
if keyIsSomeEndpoint(name) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if keyIsSomeEndpoint(name) { | |
if isDownStreamEndpointKey(name) { |
Signed-off-by: kfreez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR is a replica of #176 , since #176 has some difficulties to merge back because of the rebase issues. use this one to submit code.
this PR adopt the new manifests introduced by #173 and forget the old manifests. kept some code be comment out but not deleted in case the possible regression issue, after the old manifest deleted, these used code will be cleaned out.
this PR should've solved the issue #138, and also be part of solution to the #166 and #143
this PR also add support to WebRetriver service
Issues
#138, #166, #143
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
'n/a'
Tests
e2e regression tests passed
here is the log of searchqa result: