Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm chart: Allow users to set extra env by external configmap #170

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

lianhao
Copy link
Collaborator

@lianhao lianhao commented Jul 12, 2024

Description

  • Allow users to set extra env by external configmap through global.extraEnvConfig
  • export data-prep configuration items into its value file
  • bump chart version to upcoming 0.8.0 and adapted to v0.7 opea docker images

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)

Dependencies

n/a

Tests

verified on Xeon with recently published opea docker image(v0.7)

lianhao added 3 commits July 12, 2024 11:30
Allow user to add/overwrite extra environment variables by setting
globa.extraEnvConfig to an external configmap.

Signed-off-by: Lianhao Lu <[email protected]>
Copy link
Collaborator

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yongfengdu yongfengdu merged commit b3cbde0 into opea-project:main Jul 12, 2024
10 checks passed
@lianhao lianhao deleted the chart_version branch July 12, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants