Enhance the switch mode for GMC router service required #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pipeline. Signed-off-by: zhlsunshine <[email protected]>
Signed-off-by: zhlsunshine <[email protected]>
|
@zhlsunshine I just wonder if you have any unit tests or e2e tests to cover this case? |
Hi @daisy-ycguo, this enhancement is related to route service which has been tested by before unit test. We have 3 test functions for it: |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is submitted for #143, there are some limitations of the current switch mode in GMC, such as only one switch condition can be supported in GMC router.
This PR make sure that all conditions can be handled in switch mode.
Issues
#143
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a.Tests
Switch mode with parameter model_id==intel
Switch mode with parameter model_id==llama
