Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMC: add unit test #116

Merged
merged 2 commits into from
Jun 24, 2024
Merged

GMC: add unit test #116

merged 2 commits into from
Jun 24, 2024

Conversation

KfreeZ
Copy link
Collaborator

@KfreeZ KfreeZ commented Jun 22, 2024

Description

add unit tests for router and controller

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

Tests

coverage up to 70%

Signed-off-by: KfreeZ <[email protected]>
Copy link
Collaborator

@zhlsunshine zhlsunshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can increase the unit test coverage, LGTM

Copy link
Collaborator

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daisy-ycguo daisy-ycguo merged commit 1e3e56d into opea-project:main Jun 24, 2024
7 checks passed
xwu99 pushed a commit to xwu99/GenAIInfra that referenced this pull request Jun 24, 2024
Signed-off-by: KfreeZ <[email protected]>
Signed-off-by: Wu, Xiaochang <[email protected]>
@KfreeZ KfreeZ mentioned this pull request Jun 24, 2024
3 tasks
@KfreeZ KfreeZ deleted the increaseCoverage branch July 11, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants