Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codegen e2e test #107

Merged
merged 7 commits into from
Jun 20, 2024
Merged

add codegen e2e test #107

merged 7 commits into from
Jun 20, 2024

Conversation

KfreeZ
Copy link
Collaborator

@KfreeZ KfreeZ commented Jun 19, 2024

Description

add codegen e2e test for GMC

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

Tests

this test should passed in every CI/CD job

@KfreeZ KfreeZ requested a review from daisy-ycguo June 20, 2024 00:39
@KfreeZ
Copy link
Collaborator Author

KfreeZ commented Jun 20, 2024

@daisy-ycguo @zhlsunshine

Copy link
Collaborator

@zhlsunshine zhlsunshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@KfreeZ KfreeZ merged commit 18f53c9 into opea-project:main Jun 20, 2024
6 checks passed
@KfreeZ KfreeZ deleted the e2eCodegen branch July 11, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants