Skip to content

Commit

Permalink
The microservice port number is not configurable
Browse files Browse the repository at this point in the history
Helm chart shouldn't provide the config options for targetPort.

Signed-off-by: Dolpher Du <[email protected]>
  • Loading branch information
yongfengdu authored and daisy-ycguo committed Jul 9, 2024
1 parent 3849317 commit fbaa6ab
Show file tree
Hide file tree
Showing 8 changed files with 5 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ spec:
imagePullPolicy: IfNotPresent
ports:
- name: embedding-usvc
containerPort: {{ .Values.service.targetPort }}
containerPort: 6000
protocol: TCP
volumeMounts:
- mountPath: /tmp
Expand Down
2 changes: 1 addition & 1 deletion helm-charts/common/embedding-usvc/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
type: {{ .Values.service.type }}
ports:
- port: {{ .Values.service.port }}
targetPort: {{ .Values.service.targetPort }}
targetPort: 6000
protocol: TCP
name: embedding-usvc
selector:
Expand Down
1 change: 0 additions & 1 deletion helm-charts/common/embedding-usvc/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ service:
type: ClusterIP
# The default port for embedding service is 9000
port: 6000
targetPort: 6000

resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ spec:
imagePullPolicy: IfNotPresent
ports:
- name: reranking-usvc
containerPort: {{ .Values.service.targetPort }}
containerPort: 8000
protocol: TCP
volumeMounts:
- mountPath: /tmp
Expand Down
2 changes: 1 addition & 1 deletion helm-charts/common/reranking-usvc/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
type: {{ .Values.service.type }}
ports:
- port: {{ .Values.service.port }}
targetPort: {{ .Values.service.targetPort }}
targetPort: 8000
protocol: TCP
name: reranking-usvc
selector:
Expand Down
1 change: 0 additions & 1 deletion helm-charts/common/reranking-usvc/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ service:
type: ClusterIP
# The default port for reranking service is 9000
port: 8000
targetPort: 8000

resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
Expand Down
2 changes: 1 addition & 1 deletion helm-charts/common/retriever-usvc/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
type: {{ .Values.service.type }}
ports:
- port: {{ .Values.service.port }}
targetPort: {{ .Values.service.targetPort }}
targetPort: 7000
protocol: TCP
name: retriever-usvc
selector:
Expand Down
1 change: 0 additions & 1 deletion helm-charts/common/retriever-usvc/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ service:
type: ClusterIP
# The default port for retriever service is 7000
port: 7000
targetPort: 7000

resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
Expand Down

0 comments on commit fbaa6ab

Please sign in to comment.