instruction finetune README improvement #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rbrugaro <[email protected]>
lvliang-intel
approved these changes
Oct 5, 2024
kevinintel
approved these changes
Oct 8, 2024
ctao456
pushed a commit
to ctao456/GenAIExamples
that referenced
this pull request
Oct 9, 2024
Signed-off-by: rbrugaro <[email protected]>
JoshuaL3000
pushed a commit
to JoshuaL3000/GenAIExamples
that referenced
this pull request
Oct 16, 2024
Signed-off-by: rbrugaro <[email protected]>
wangkl2
pushed a commit
to wangkl2/GenAIExamples
that referenced
this pull request
Dec 11, 2024
Signed-off-by: ZePan110 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to successfully run the instruction finetune on Gaudi 2 and I am just adding a few comments to the README for clarity.
I tested with a more recent Gaudi image than the one in Dockerfile.intel_hpu
I used:
FROM vault.habana.ai/gaudi-docker/1.17.0/ubuntu22.04/habanalabs/pytorch-installer-2.3.1:latest as hpu
Instead of:
FROM opea/habanalabs:1.16.1-pytorch-installer-2.2.2 as hpu
This PR only has the readme additions but let me know if you want a PR to upgrade that as well.