Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MultimodalQnA as MMRAG usecase in Example #751

Merged
merged 111 commits into from
Sep 14, 2024

Conversation

tileintel
Copy link
Collaborator

@tileintel tileintel commented Sep 6, 2024

Description

Add MultimodalQnA as MMRAG usecase in Example. This PR is ready to review and merge.

Issues

RFC: https://github.com/opea-project/docs/pull/49/files
Issue: #358

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

gradio

Tests

  • GenAIExamples/MultimodalQnA/tests/test_compose_on_gaudi.sh
  • GenAIExamples/MultimodalQnA/tests/test_compose_on_xeon.sh

@tileintel tileintel mentioned this pull request Sep 6, 2024
tileintel and others added 23 commits September 6, 2024 06:03
Signed-off-by: Tiep Le <[email protected]>
Signed-off-by: Tiep Le <[email protected]>
Signed-off-by: Tiep Le <[email protected]>
Signed-off-by: Tiep Le <[email protected]>
Signed-off-by: Tiep Le <[email protected]>
Signed-off-by: Tiep Le <[email protected]>
Signed-off-by: Tiep Le <[email protected]>
Signed-off-by: Tiep Le <[email protected]>
Signed-off-by: Tiep Le <[email protected]>
Signed-off-by: Tiep Le <[email protected]>
Signed-off-by: Tiep Le <[email protected]>
Signed-off-by: Tiep Le <[email protected]>
Signed-off-by: Tiep Le <[email protected]>
Signed-off-by: Tiep Le <[email protected]>
Signed-off-by: Tiep Le <[email protected]>
@tileintel
Copy link
Collaborator Author

@chensuyue @lvliang-intel @Spycsh I have taken into account all of your feedbacks. Can you please review this PR again and merge if you don't have any further feedback? Thank a lot for your support.

@chensuyue
Copy link
Collaborator

Please also update the related image name in GenAIComps.

@chensuyue
Copy link
Collaborator

@tileintel We still have some concern about the example name, @kevinintel will follow with you.

@chensuyue chensuyue added the WIP label Sep 13, 2024
@chensuyue chensuyue added this to the v1.0 milestone Sep 13, 2024
Signed-off-by: Tiep Le <[email protected]>
Signed-off-by: Tiep Le <[email protected]>
@chensuyue chensuyue marked this pull request as draft September 13, 2024 09:10
@chensuyue
Copy link
Collaborator

chensuyue commented Sep 13, 2024

opea-project/GenAIComps#686 align image name

@chensuyue chensuyue marked this pull request as ready for review September 14, 2024 08:22
@tileintel tileintel changed the title Add MultimodalRAGWithVideos as MMRAG usecase in Example Add MultimodalQnA as MMRAG usecase in Example Sep 14, 2024
@chensuyue chensuyue removed the WIP label Sep 14, 2024
@chensuyue chensuyue merged commit b6cce35 into opea-project:main Sep 14, 2024
12 checks passed
wangkl2 pushed a commit to wangkl2/GenAIExamples that referenced this pull request Dec 11, 2024
* Remove unused imports

Signed-off-by: Dan Middleton <[email protected]>

* Remove unused imports

Signed-off-by: Dan Middleton <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Dan Middleton <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants