Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more code owners #711

Merged
merged 5 commits into from
Sep 3, 2024
Merged

add more code owners #711

merged 5 commits into from
Sep 3, 2024

Conversation

kevinintel
Copy link
Collaborator

Description

Add more code owners

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • [Y] Others (enhancement, documentation, validation, etc.)

Dependencies

n/a

Tests

n/a

Copy link

github-actions bot commented Sep 2, 2024

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@kevinintel kevinintel mentioned this pull request Sep 2, 2024
.github/CODEOWNERS Outdated Show resolved Hide resolved
@dbkinder
Copy link
Collaborator

dbkinder commented Sep 3, 2024

@kevinintel @hshen14 This PR has errors as noted by GitHub:
(there shouldn't be a comma, only a space between owners)

We also need a default entry to catch files in directories not mentioned, including all the files in the root such as README.md, docker_images_list.md, supported_examples.md.

Invalid owner on line 7:  
…Retriever/ [email protected], [email protected]
Unknown owner on line 12: make sure a user with the email address [email protected] exists and has write access to the repository
/ProductivitySuite/ [email protected]

@kevinintel
Copy link
Collaborator Author

kevinintel commented Sep 3, 2024

will grant the permission

@ftian1 ftian1 merged commit 7f89797 into main Sep 3, 2024
10 checks passed
@ftian1 ftian1 deleted the add_codeowner branch September 3, 2024 06:58
Copy link
Collaborator

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ftian1 @kevinintel @hshen14 @lvliang-intel GitHub is complaining that this CODEOWNERS file contains errors.

Also, by putting /*/ at the end of the CODEOWNERS, it will assign [email protected] as the owner of all directories (last matching pattern wins). You should put this at the top of the file. We're also missing a pattern for files in the repo root (e.g, for README.md, docker_images_list.md, pyproject.toml, etc.)

xuechendi pushed a commit to xuechendi/GenAIExamples that referenced this pull request Sep 9, 2024
* add more code owners

* add owner

* remove comma

* add owner
dmsuehir pushed a commit to dmsuehir/GenAIExamples that referenced this pull request Sep 11, 2024
* add more code owners

* add owner

* remove comma

* add owner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants