-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes for CodeGen Xeon and Gaudi Kubernetes codegen.yaml and doc updates #613
Merged
daisy-ycguo
merged 7 commits into
opea-project:main
from
dmsuehir:dina/codegen_k8s_manifest_fixes
Aug 23, 2024
Merged
Minor fixes for CodeGen Xeon and Gaudi Kubernetes codegen.yaml and doc updates #613
daisy-ycguo
merged 7 commits into
opea-project:main
from
dmsuehir:dina/codegen_k8s_manifest_fixes
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c updates Signed-off-by: dmsuehir <[email protected]>
2 tasks
ashahba
approved these changes
Aug 16, 2024
…degen_k8s_manifest_fixes
lianhao
reviewed
Aug 20, 2024
…degen_k8s_manifest_fixes Signed-off-by: dmsuehir <[email protected]>
Signed-off-by: dmsuehir <[email protected]>
daisy-ycguo
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…degen_k8s_manifest_fixes
…/GenAIExamples into dina/codegen_k8s_manifest_fixes
I don't have objection to have this merged in. I'm just curious about how to get outdated conversion resolved on github PR pages. |
chensuyue
pushed a commit
that referenced
this pull request
Aug 23, 2024
…c updates (#613) * Minor fixes for CodeGen Xeon and Gaudi Kubernetes codegen.yaml and doc updates Signed-off-by: dmsuehir <[email protected]> (cherry picked from commit c25063f)
dmsuehir
added a commit
to dmsuehir/GenAIExamples
that referenced
this pull request
Sep 11, 2024
…c updates (opea-project#613) * Minor fixes for CodeGen Xeon and Gaudi Kubernetes codegen.yaml and doc updates Signed-off-by: dmsuehir <[email protected]>
wangkl2
pushed a commit
to wangkl2/GenAIExamples
that referenced
this pull request
Dec 11, 2024
* update upload_training_files format Signed-off-by: Yue, Wenjiao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has a few updates based on issues that I ran into when deploying the CodeGen example on a cluster for xeon and Gaudi. The following issues are addressed in the PR:
/mnt/opea-models
directory on the nodescodegen.yaml
files gave an error like:""
fixes the issue. [EDIT: this was resolved in PR 630]curl
command failed like "curl: (18) transfer closed with outstanding read data remaining" and it was just because the service wasn't ready yet. Also, knowing how to check the logs is useful for watching the status and figuring out if thecurl
command is failing because of an error.hugepages-2Mi
/memory
to the resource limits. The habana documentation for Kubernetes shows it usinghugepages-2Mi
andmemory
in the resources, so that seems to be the recommended config.Issues
N/A
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
Manually tested the changes on a Kubernetes cluster with Xeon and Gaudi 2 nodes.