Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc]Add a micro/mega service WorkFlow for DocSum #537

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

louie-tsai
Copy link
Collaborator

@louie-tsai louie-tsai commented Aug 7, 2024

added a micro/megaservice workflow for Doc Sum

Description

Need a workflow how we build DocSum via mega and micro service

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

NA

Tests

NA

@louie-tsai louie-tsai force-pushed the Flow_DocSum branch 4 times, most recently from 4320cd4 to 5b5d588 Compare August 8, 2024 16:41
@alexsin368
Copy link

Looks good.

@louie-tsai louie-tsai changed the title Add a micro/mega service WorkFlow for DocSum [Doc]Add a micro/mega service WorkFlow for DocSum Aug 9, 2024
@chensuyue
Copy link
Collaborator

pre-commit.ci is not able to fix your branch (I think it's because intel-ai-tce org reject it), please run the test locally and push again.
steps:

pip install pre-commit
pre-commit install
git commit -s -m "fix format issue"

@louie-tsai louie-tsai force-pushed the Flow_DocSum branch 3 times, most recently from c2d96c5 to 9d31faf Compare August 19, 2024 17:19
@louie-tsai
Copy link
Collaborator Author

pre-commit.ci is not able to fix your branch (I think it's because intel-ai-tce org reject it), please run the test locally and push again. steps:

pip install pre-commit
pre-commit install
git commit -s -m "fix format issue"

thanks. I used below instruction instead.

pre-commit run --all-files

one quick question, should I add any github user to the forked repo to avoid this issue in the future?

@louie-tsai
Copy link
Collaborator Author

Looks good.

please help to approve it if it looks good to you.

added a micro/megaservice workflow for Doc Sum

Signed-off-by: Tsai, Louie <[email protected]>
Signed-off-by: Tsai, Louie <[email protected]>
Signed-off-by: Tsai, Louie <[email protected]>
Copy link
Collaborator

@yinghu5 yinghu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved it

@yinghu5 yinghu5 merged commit 343d614 into opea-project:main Aug 21, 2024
4 checks passed
dmsuehir pushed a commit to dmsuehir/GenAIExamples that referenced this pull request Sep 11, 2024
* Update README.md

added a micro/megaservice workflow for Doc Sum

Signed-off-by: Tsai, Louie <[email protected]>

* Update README.md

Signed-off-by: Tsai, Louie <[email protected]>

* fix format issue

Signed-off-by: Tsai, Louie <[email protected]>

---------

Signed-off-by: Tsai, Louie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants