Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine docker_compose for dataprep param settings #486

Merged
merged 24 commits into from
Aug 6, 2024

Conversation

letonghan
Copy link
Collaborator

Description

Add TEI_ENDPOINT for dataprep configuration

Issues

Related to PR 351

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

Describe the tests that you ran to verify your changes.

Copy link
Collaborator

@ashahba ashahba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @letonghan for the PR.
LGTM!
At some point all params within Docker or Docker compose need to be documented within README files.

@letonghan
Copy link
Collaborator Author

E2E test on xeon failed for frontend test.
@WenjiaoYue is helping with it.

letonghan and others added 17 commits July 31, 2024 10:44
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
@letonghan
Copy link
Collaborator Author

E2E test failed caused by Dataprep Microservice bug.
Will be fixed by PR opea-project/GenAIComps#404

Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
@letonghan letonghan merged commit 3913c7b into opea-project:main Aug 6, 2024
11 checks passed
yogeshmpandey pushed a commit to hteeyeoh/GenAIExamples that referenced this pull request Aug 12, 2024
* add TEI_ENDPOINT for dataprep

Signed-off-by: letonghan <[email protected]>

* add TEI_ENDPOINT for dataprep

Signed-off-by: letonghan <[email protected]>

* update ui test file

Signed-off-by: letonghan <[email protected]>

* add dataprep test into script

Signed-off-by: letonghan <[email protected]>

* refine e2e test of chatqna

Signed-off-by: letonghan <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix missing dockerfile path

Signed-off-by: letonghan <[email protected]>

* check test issue

Signed-off-by: letonghan <[email protected]>

* check dataprep log

Signed-off-by: letonghan <[email protected]>

* reverse codetrans

Signed-off-by: letonghan <[email protected]>

* cd log path

Signed-off-by: letonghan <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add hf token in compose yaml

Signed-off-by: letonghan <[email protected]>

* add redis_host

Signed-off-by: letonghan <[email protected]>

* add upload link test

Signed-off-by: letonghan <[email protected]>

* re-format validate dataprep

Signed-off-by: letonghan <[email protected]>

* fix typo

Signed-off-by: letonghan <[email protected]>

* fix frontend env name

Signed-off-by: letonghan <[email protected]>

* fix ci issue

Signed-off-by: letonghan <[email protected]>

---------

Signed-off-by: letonghan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@letonghan letonghan deleted the dataprep/params branch September 23, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants