Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new example of Translation for GenAIExample #455

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

zhlsunshine
Copy link

Description

  1. Add new example of Translation in GenAIExample
  2. Add e2e test for example of Translation in GenAIExample

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

n/a.

Tests

Please check the PR#220 in GenAIInfra repo.

@zhlsunshine zhlsunshine force-pushed the e2eTranslation branch 2 times, most recently from 2cd9073 to 4b6ae77 Compare July 24, 2024 10:17
Copy link
Collaborator

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daisy-ycguo daisy-ycguo merged commit d0b028d into opea-project:main Jul 25, 2024
11 checks passed
yogeshmpandey pushed a commit to hteeyeoh/GenAIExamples that referenced this pull request Aug 12, 2024
* Add Translation GMC pipeline
Signed-off-by: zhlsunshine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants