Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update visualQnA chinese version #354

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Conversation

WenjiaoYue
Copy link
Collaborator

@WenjiaoYue WenjiaoYue commented Jul 1, 2024

Description

update visualQnA chinese version.

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

no

Tests

CI pass.

Copy link
Collaborator

@lvliang-intel lvliang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to support both English and Chinese version UI.

@hshen14 hshen14 marked this pull request as draft July 8, 2024 04:51
@WenjiaoYue WenjiaoYue marked this pull request as ready for review July 10, 2024 08:51
@WenjiaoYue
Copy link
Collaborator Author

We need to support both English and Chinese version UI.

Currently, VisualQnA supports both English and Chinese versions of the UI. Due to upgrades in Gradio, the previous method of detecting browser language no longer applies. Users can switch to their preferred version by specifying the language during startup, as detailed in the updated README.

@hshen14 hshen14 merged commit 4978959 into main Jul 10, 2024
12 checks passed
@hshen14 hshen14 deleted the wenjiao/visualQnA_Chinese_version branch July 10, 2024 15:43
yogeshmpandey pushed a commit to yogeshmpandey/GenAIExamples that referenced this pull request Jul 18, 2024
* update visualQnA chinese version

Signed-off-by: WenjiaoYue <[email protected]>


---------

Signed-off-by: WenjiaoYue <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yogeshmpandey pushed a commit to hteeyeoh/GenAIExamples that referenced this pull request Aug 12, 2024
* update visualQnA chinese version

Signed-off-by: WenjiaoYue <[email protected]>


---------

Signed-off-by: WenjiaoYue <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants