Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to notify two gaudi cards needed #293

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

louie-tsai
Copy link
Collaborator

@louie-tsai louie-tsai commented Jun 14, 2024

ChatQnA needs two gaudi cards. put a note to inform users.

Description

ChatQnA needs two gaudi cards. put a note to inform users.

Issues

N/A

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

NA

Tests

Describe the tests that you ran to verify your changes.

@louie-tsai louie-tsai force-pushed the main branch 3 times, most recently from 6391c01 to 12644be Compare June 17, 2024 14:14
@daisy-ycguo
Copy link
Collaborator

daisy-ycguo commented Jun 20, 2024

@louie-tsai Thank you for your PR. Yet I don't think ChatQnA requires at least 2 gaudi cards, because I've run ChatQnA successfully using 1 Gaudi card. I don't agree with your changes.

@louie-tsai
Copy link
Collaborator Author

louie-tsai commented Jun 26, 2024

@louie-tsai Thank you for your PR. Yet I don't think ChatQnA requires at least 2 gaudi cards, because I've run ChatQnA successfully using 1 Gaudi card. I don't agree with your changes.

@daisy-ycguo
Hi
I used 1 card VM instance from IDC, and tgi-service didn't run successfully in that IDC VM.
image

While I tried to restart it with "docker compose -f docker_compose.yaml up tgi-service", I saw below issue.
image

However, everything works fine if I used 8 cards IDC instance.

@louie-tsai
Copy link
Collaborator Author

@louie-tsai Thank you for your PR. Yet I don't think ChatQnA requires at least 2 gaudi cards, because I've run ChatQnA successfully using 1 Gaudi card. I don't agree with your changes.

@daisy-ycguo Hi I used 1 card VM instance from IDC, and tgi-service didn't run successfully in that IDC VM. image

While I tried to restart it with "docker compose -f docker_compose.yaml up tgi-service", I saw below issue. image

However, everything works fine if I used 8 cards IDC instance.

once I changed tei-embedding-server from gaudi to cpu, it works.
image

@kevinintel
Copy link
Collaborator

@louie, please fix DCO

@louie-tsai louie-tsai force-pushed the main branch 2 times, most recently from 5651251 to d5802f8 Compare July 10, 2024 00:34
ChatQnA needs two gaudi cards. put a note to inform users.

Signed-off-by: Tsai, Louie <[email protected]>
Signed-off-by: Tsai, Louie <[email protected]>
@louie-tsai
Copy link
Collaborator Author

@louie, please fix DCO

@kevinintel
thanks for reminding. addressed it accordingly.

@kevinintel
Copy link
Collaborator

looks like it has conflicts

@chensuyue chensuyue merged commit 70a50d8 into opea-project:main Aug 5, 2024
4 checks passed
yogeshmpandey pushed a commit to hteeyeoh/GenAIExamples that referenced this pull request Aug 12, 2024
wangkl2 pushed a commit to wangkl2/GenAIExamples that referenced this pull request Dec 11, 2024
* Support https for microservice

Signed-off-by: lvliang-intel <[email protected]>

---------

Signed-off-by: lvliang-intel <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants