Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hyperlinks and paths validation. #132

Merged
merged 9 commits into from
Sep 20, 2024
Merged

Add hyperlinks and paths validation. #132

merged 9 commits into from
Sep 20, 2024

Conversation

ZePan110
Copy link
Collaborator

@ZePan110 ZePan110 commented Sep 19, 2024 •
edited
Loading

Description

Add hyperlinks and paths validation.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@ZePan110
Copy link
Collaborator Author

Hi @Spycsh Can you help check

GenAIEval/examples/AudioQnA/README.md

Line 6 in ac52f79

We evaluate the ASR accuracy on the test set of librispeech [dataset](andreagasparini/librispeech_test_only), which contains 2620 records of audio and texts.
, The tool reports an error when checking, I can't find where this path points to.
image

lkk12014402 pushed a commit that referenced this pull request Sep 19, 2024
@XuehaoSun @pre-commit-ci
Add check requirements workflow (#132)
5c59dce 
* Add workflow to check requirements in pull requests

Signed-off-by: Sun, Xuehao <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Sun, Xuehao <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@ZePan110
Compatible with the origin of PR.
4da5b2c 
Signed-off-by: ZePan110 <[email protected]>
@ZePan110
Fix errors.
58f1b00 
Signed-off-by: ZePan110 <[email protected]>
@ZePan110
Fix link error.
7a92954 
Signed-off-by: ZePan110 <[email protected]>
@ZePan110
Fix path error.
a2c2e7d 
Signed-off-by: ZePan110 <[email protected]>
@ZePan110
Redefine output.
b57de63 
Signed-off-by: ZePan110 <[email protected]>
@chensuyue chensuyue merged commit df58fe5 into main Sep 20, 2024
11 checks passed
@chensuyue chensuyue deleted the zepan/dev branch September 20, 2024 02:51
adkakne pushed a commit to adkakne/GenAIEval that referenced this pull request Sep 20, 2024
@ZePan110 @adkakne
Add hyperlinks and paths validation. (opea-project#132)
6502c68 
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: aasavari <[email protected]>
adkakne pushed a commit to adkakne/GenAIEval that referenced this pull request Sep 20, 2024
@ZePan110 @adkakne
Add hyperlinks and paths validation. (opea-project#132)
50d4167 
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: aasavari <[email protected]>
XinyuYe-Intel pushed a commit that referenced this pull request Sep 24, 2024
@adkakne @daisy-ycguo
@lkk12014402 @pre-commit-ci @ZePan110
Minimize requirements for user data for OPEA ragas (#136)
f1593ea 
* minimized required fields/columns in user data

Signed-off-by: aasavari <[email protected]>

* add bench-target as the prefix of output folder (#133)

Signed-off-by: Yingchun Guo <[email protected]>
Signed-off-by: aasavari <[email protected]>

* remove examples. (#135)

Co-authored-by: root <[email protected]>
Signed-off-by: aasavari <[email protected]>

* minor naming correction to maintain consistency

Signed-off-by: aasavari <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: aasavari <[email protected]>

* Add hyperlinks and paths validation. (#132)

Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: aasavari <[email protected]>

* added support for older version of ragas

Signed-off-by: aasavari <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: aasavari <[email protected]>
Signed-off-by: Yingchun Guo <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Co-authored-by: Ying Chun Guo <[email protected]>
Co-authored-by: lkk <[email protected]>
Co-authored-by: root <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ZePan110 <[email protected]>
lvliang-intel pushed a commit that referenced this pull request Sep 24, 2024
@adkakne @daisy-ycguo
@lkk12014402 @pre-commit-ci @ZePan110
Add README for running OPEA ragas using HF endpoint on Gaudi (#137)
0dff0d3 
* minimized required fields/columns in user data

Signed-off-by: aasavari <[email protected]>

* add bench-target as the prefix of output folder (#133)

Signed-off-by: Yingchun Guo <[email protected]>
Signed-off-by: aasavari <[email protected]>

* remove examples. (#135)

Co-authored-by: root <[email protected]>
Signed-off-by: aasavari <[email protected]>

* minor naming correction to maintain consistency

Signed-off-by: aasavari <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: aasavari <[email protected]>

* Add hyperlinks and paths validation. (#132)

Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: aasavari <[email protected]>

* adding README for OPEA ragas

Signed-off-by: aasavari <[email protected]>

* adding python3 syntax to README

Signed-off-by: aasavari <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: aasavari <[email protected]>
Signed-off-by: Yingchun Guo <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Co-authored-by: Ying Chun Guo <[email protected]>
Co-authored-by: lkk <[email protected]>
Co-authored-by: root <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ZePan110 <[email protected]>
XinyuYe-Intel pushed a commit that referenced this pull request Oct 15, 2024
@adkakne @daisy-ycguo
@lkk12014402 @pre-commit-ci @ZePan110 @lvliang-intel
Ragaaf (RAG assessment annotation free) (#157)
2413e70 
* minimized required fields/columns in user data

Signed-off-by: aasavari <[email protected]>

* add bench-target as the prefix of output folder (#133)

Signed-off-by: Yingchun Guo <[email protected]>
Signed-off-by: aasavari <[email protected]>

* remove examples. (#135)

Co-authored-by: root <[email protected]>
Signed-off-by: aasavari <[email protected]>

* minor naming correction to maintain consistency

Signed-off-by: aasavari <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: aasavari <[email protected]>

* Add hyperlinks and paths validation. (#132)

Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: aasavari <[email protected]>

* added support for older version of ragas

Signed-off-by: aasavari <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* testing automatic validation of ragas metrics

Signed-off-by: aasavari <[email protected]>

* removing summarization_score metric

Signed-off-by: aasavari <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* upgrading ragas from 0.1.16 to 0.1.19

Signed-off-by: aasavari <[email protected]>

* adding annotation free RAG assessment

Signed-off-by: aasavari <[email protected]>

* improved README

Signed-off-by: aasavari <[email protected]>

* adding jsonlines to requirements

Signed-off-by: aasavari <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fulfilled feature request - allow unit test case for RAGAAF

Signed-off-by: aasavari <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* removing extra inputs from evaluation

Signed-off-by: aasavari <[email protected]>

* correcting class name for unit test

Signed-off-by: aasavari <[email protected]>

* test needs local ID

Signed-off-by: aasavari <[email protected]>

---------

Signed-off-by: aasavari <[email protected]>
Signed-off-by: Yingchun Guo <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Co-authored-by: Ying Chun Guo <[email protected]>
Co-authored-by: lkk <[email protected]>
Co-authored-by: root <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ZePan110 <[email protected]>
Co-authored-by: lvliang-intel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvliang-intel lvliang-intel lvliang-intel approved these changes

@chensuyue chensuyue chensuyue approved these changes

@lkk12014402 lkk12014402 Awaiting requested review from lkk12014402 lkk12014402 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZePan110 @chensuyue @lvliang-intel