Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing end of file chars #874

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

ashahba
Copy link
Collaborator

@ashahba ashahba commented Nov 8, 2024

Description

This PR fixes missing end of file chars across the repo.
This is the command I used to fix them all in one shot:

git ls-files -z | while IFS= read -rd '' f; do if file --mime-encoding "$f" | grep -qv binary; then tail -c1 < "$f" | read -r _ || echo >> "$f"; fi; done

Issues

Currently the check for missing end of file's is failing the linter tests but we have many files across the repo with that same issue which needs fix anyway.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.: None

Tests

Describe the tests that you ran to verify your changes.
Lint tests should pass without any issues since the files in the PR was touched.

Signed-off-by: Abolfazl Shahbazi <[email protected]>
@ashahba ashahba added this to the v1.1 milestone Nov 8, 2024
@ashahba ashahba added the r1.1 label Nov 8, 2024
@hshen14 hshen14 requested a review from chensuyue November 12, 2024 23:21
@chensuyue chensuyue merged commit f1594cb into opea-project:main Nov 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants