Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to comps/llms/text-generation/README #678

Merged
merged 4 commits into from
Sep 14, 2024

Conversation

HarshaRamayanam
Copy link
Contributor

@HarshaRamayanam HarshaRamayanam commented Sep 11, 2024

Description

Note: This PR includes changes from another PR which got closed due to merge conflicts and file changes. Thanks to @dbkinder for that PR review

This PR makes changes to this README from comps/llms/text-generation directory. Most of the changes include

  • re-arranging the headings and their contents to places that makes most sense
  • breaking long bash commands into lines
  • rectifying incorrect script names
  • modified bash commands to make them even more easily copy-paste-able.

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

n/a

Tests

n/a

Signed-off-by: Harsha Ramayanam <[email protected]>
@ftian1 ftian1 merged commit 18092f3 into opea-project:main Sep 14, 2024
4 checks passed
chensuyue pushed a commit that referenced this pull request Sep 18, 2024
* Added changes per dbkinder's review

Signed-off-by: Harsha Ramayanam <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Harsha Ramayanam <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 18092f3)
@HarshaRamayanam HarshaRamayanam deleted the hramayan/comps_readme branch September 18, 2024 17:10
lkk12014402 pushed a commit that referenced this pull request Sep 19, 2024
Signed-off-by: Yue, Wenjiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants