Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding dataprep support for CLIP based models for VideoRAGQnA example for v1.0 #621

Merged
merged 32 commits into from
Sep 11, 2024
Merged

adding dataprep support for CLIP based models for VideoRAGQnA example for v1.0 #621

merged 32 commits into from
Sep 11, 2024

Conversation

srinarayan-srikanthan
Copy link
Collaborator

Description

Add support for CLIP based multimodal dataprep for VideoRAG usecase.

Issues

The RFC is under review : opea-project/docs#49

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

srinarayan-srikanthan and others added 8 commits September 2, 2024 20:09
@srinarayan-srikanthan
dataprep service
b469976 
Signed-off-by: srinarayan-srikanthan <[email protected]>
@srinarayan-srikanthan
dataprep updates
e87b159 
Signed-off-by: srinarayan-srikanthan <[email protected]>
@srinarayan-srikanthan
rearranged dirs
dc3b5b7 
Signed-off-by: srinarayan-srikanthan <[email protected]>
@srinarayan-srikanthan
added readme
4045cb8 
Signed-off-by: srinarayan-srikanthan <[email protected]>
@srinarayan-srikanthan
removed checks
d4c9441 
Signed-off-by: srinarayan-srikanthan <[email protected]>
@srinarayan-srikanthan
added features
40117cb 
Signed-off-by: srinarayan-srikanthan <[email protected]>
@srinarayan-srikanthan
added get method
f9d1e2b 
Signed-off-by: srinarayan-srikanthan <[email protected]>
@srinarayan-srikanthan
Merge branch 'opea-project:main' into sri-clip-dataprep
cde7557
@srinarayan-srikanthan
Copy link
Collaborator Author

@chensuyue can you please tag this PR with 'V1.0' Milestone

@BaoHuiling BaoHuiling added this to the v1.0 milestone Sep 5, 2024
@BaoHuiling BaoHuiling mentioned this pull request Sep 5, 2024
Merged
4 tasks
BaoHuiling and others added 4 commits September 6, 2024 17:33
@BaoHuiling
Copy link
Collaborator

BaoHuiling commented Sep 10, 2024 •
edited
Loading

@chensuyue hello Suyue, the File change warning outputs below:

  • echo 'Please check if the added comps/dataprep/vdms/multimodal_langchain/docker/Dockerfile is included in the yaml under path /home/runner/work/GenAIComps/GenAIComps/.github/workflows/docker/compose/dataprep-compose-cd.yaml.'
    Please check if the added comps/dataprep/vdms/multimodal_langchain/docker/Dockerfile is included in the yaml under path /home/runner/work/GenAIComps/GenAIComps/.github/workflows/docker/compose/dataprep-compose-cd.yaml.
  • no_add=TRUE
  • [[ TRUE == \T\R\U\E ]]
  • exit 1
    Error: Process completed with exit code 1.

I have added VDMS into the /workflows/docker/compose/dataprep-compose-cd.yaml file, but what is this used for?

@BaoHuiling
move test script
9fe2571 
Signed-off-by: BaoHuiling <[email protected]>
@BaoHuiling
Copy link
Collaborator

@lvliang-intel @Spycsh @XinyuYe-Intel We see the repo is been reorged, pls, help review this PR so we could be merged today

@chensuyue
Copy link
Collaborator

chensuyue commented Sep 11, 2024 •
edited
Loading

@chensuyue hello Suyue, the File change warning outputs below:

  • echo 'Please check if the added comps/dataprep/vdms/multimodal_langchain/docker/Dockerfile is included in the yaml under path /home/runner/work/GenAIComps/GenAIComps/.github/workflows/docker/compose/dataprep-compose-cd.yaml.'
    Please check if the added comps/dataprep/vdms/multimodal_langchain/docker/Dockerfile is included in the yaml under path /home/runner/work/GenAIComps/GenAIComps/.github/workflows/docker/compose/dataprep-compose-cd.yaml.
  • no_add=TRUE
  • [[ TRUE == \T\R\U\E ]]
  • exit 1
    Error: Process completed with exit code 1.

I have added VDMS into the /workflows/docker/compose/dataprep-compose-cd.yaml file, but what is this used for?

This is used for release image build/scan/publish.

@BaoHuiling
add name for build
1fbc343 
Signed-off-by: BaoHuiling <[email protected]>
@lvliang-intel lvliang-intel merged commit f84d91a into opea-project:main Sep 11, 2024
9 checks passed
lkk12014402 pushed a commit that referenced this pull request Sep 19, 2024
@yinghu5 @pre-commit-ci
doc fix: Update README.md to remove specific dicscription of paragrap…
5a9c109 
…h-1 (#621)

* Update README.md

According to #opea-project/GenAIExamples#338: 

The motivation paragraph 2 is more general and perhaps should move up as paragraph-1. Original paragraph-1 gets too specific into legal documents prematurely.

so Remove the paragraph 1 as it is not related.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BaoHuiling BaoHuiling BaoHuiling left review comments

@chensuyue chensuyue chensuyue left review comments

@lvliang-intel lvliang-intel lvliang-intel approved these changes

@yinghu5 yinghu5 yinghu5 approved these changes

@Spycsh Spycsh Awaiting requested review from Spycsh

@lkk12014402 lkk12014402 Awaiting requested review from lkk12014402

@XinyuYe-Intel XinyuYe-Intel Awaiting requested review from XinyuYe-Intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@srinarayan-srikanthan @BaoHuiling @chensuyue @yinghu5 @XinyuYe-Intel @lvliang-intel