Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align parameters for "max_token, repetition_penalty,presence_penalty,frequency_penalty" #608

Merged
merged 33 commits into from
Sep 18, 2024
Merged

Align parameters for "max_token, repetition_penalty,presence_penalty,frequency_penalty" #608

merged 33 commits into from
Sep 18, 2024

Conversation

XinyaoWa
Copy link
Collaborator

@XinyaoWa XinyaoWa commented Sep 4, 2024 •
edited
Loading

Description

  1. Support and clarify the usage for frequency_penalty/presence_penalty/repetition_penalty
  1. Align to max_tokens for LLM
  • Comps: LLMs use max_tokens, others use max_new_tokens
  • Examples(keep unchanged): Most use max_tokens
  1. Fix langchain version issue for faq/vllm

Issues

opea-project/GenAIExamples#673

@XinyaoWa
align max_tokens
56e3791 
Signed-off-by: Xinyao Wang <[email protected]>
@XinyaoWa
aligin repetition_penalty
ddea461 
Signed-off-by: Xinyao Wang <[email protected]>
@XinyaoWa XinyaoWa mentioned this pull request Sep 4, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
comps/cores/mega/gateway.py 35.32% <ø> (ø)
comps/cores/proto/api_protocol.py 96.00% <100.00%> (+0.01%) ⬆️
comps/cores/proto/docarray.py 99.28% <100.00%> (+0.03%) ⬆️

@lvliang-intel
Copy link
Collaborator

@XinyaoWa,
please check the CI issues.

@chensuyue chensuyue modified the milestones: v0.9, v1.0 Sep 5, 2024
@chensuyue chensuyue removed this from the v1.0 milestone Sep 11, 2024
@XinyaoWa XinyaoWa changed the title Align parameters for "max_new_tokens" and "repetition_penalty" Align parameters for "max_new_token, repetition_penalty,presence_penalty,frequency_penalty" Sep 13, 2024
@XinyaoWa
fix bug
3acd922 
Signed-off-by: Xinyao Wang <[email protected]>
@XinyaoWa
fix bug
2a6f15f 
Signed-off-by: Xinyao Wang <[email protected]>
@XinyaoWa
fix bug
4f5d3b3 
Signed-off-by: Xinyao Wang <[email protected]>
@XinyaoWa
fix bug
8c7adf1 
Signed-off-by: Xinyao Wang <[email protected]>
@XinyaoWa
Merge remote-tracking branch 'origin/main' into align_param
9ff5eef
@XinyaoWa
merge conflict
5f15e0a 
Signed-off-by: Xinyao Wang <[email protected]>
@lkk12014402
Copy link
Collaborator

LGTM

@XinyaoWa XinyaoWa mentioned this pull request Sep 18, 2024
Closed
1 task
@XinyaoWa XinyaoWa changed the title Align parameters for "max_new_token, repetition_penalty,presence_penalty,frequency_penalty" Align parameters for "max_token, repetition_penalty,presence_penalty,frequency_penalty" Sep 18, 2024
XinyaoWa and others added 10 commits September 18, 2024 13:06
@lvliang-intel lvliang-intel merged commit 3a31295 into opea-project:main Sep 18, 2024
16 checks passed
lkk12014402 pushed a commit that referenced this pull request Sep 19, 2024
@chensuyue
remove continue-on-error: true to stop the test when image build fail…
6296e9f 
…ed (#608)

Signed-off-by: chensuyue <[email protected]>
This was referenced Sep 25, 2024
Merged
Merged
@XinyaoWa XinyaoWa mentioned this pull request Oct 17, 2024
Merged
4 tasks
@XinyaoWa XinyaoWa deleted the align_param branch November 7, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvliang-intel lvliang-intel lvliang-intel left review comments

@XuhuiRen XuhuiRen XuhuiRen approved these changes

@lkk12014402 lkk12014402 lkk12014402 approved these changes

@hshen14 hshen14 hshen14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@XinyaoWa @lvliang-intel @lkk12014402 @hshen14 @XuhuiRen @chensuyue @kevinintel