-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Megaservice support for MMRAG VideoRAGQnA usecase #603
Conversation
Signed-off-by: BaoHuiling <[email protected]>
for more information, see https://pre-commit.ci
@tileintel Hello Tiep, I raise this PR for my megaservice. It's independent from you megaservice, just want to let you know. Thanks |
Codecov ReportAttention: Patch coverage is
|
@chensuyue Hello Suyue, does this change requires additional test script/function? If yes, where to add? |
@ftian1 @chensuyue @ZePan110 Hello, anyone has comment on this one? |
please add unit tests to improve the code coverage. |
No problem. Where should I add it, or do you have any references? I didn't saw the unit test for other gateways. |
https://github.com/opea-project/GenAIComps/tree/main/tests/cores/mega |
Signed-off-by: BaoHuiling <[email protected]>
for more information, see https://pre-commit.ci
Test script added at tests/cores/mega/test_service_orchestrator_with_videoragqnagateway.py. |
Signed-off-by: BaoHuiling <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: BaoHuiling <[email protected]>
for more information, see https://pre-commit.ci
Per Chang, Hanwen's requirement, update related code structure based on PR #625 |
0b528f9
to
b2de211
Compare
Rebase the changes per @letonghan 's request, will wait until #625 is merged |
Hello, @XuhuiRen @kevinintel the CI is all passed, could you help to merge the code? We have another PR in example repo depending on this, I’m afraid we don’t have enough time to wait until the Reorg changes merged. |
Description
Add support for upcoming MMRAG VideoRAGQnA usecase in GenAIExamples, the PR is under developing.
Also fix bug founded
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a
.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
tests/cores/mega/test_service_orchestrator_with_videoragqnagateway.py