Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for PR 496 to add format_video_name function #602

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

BaoHuiling
Copy link
Collaborator

@BaoHuiling BaoHuiling commented Sep 3, 2024

Description

Extend rerank functionality to support handle unregular names with video name format function, for example names as follow
[
"op_1_0320241830_interval_0",
"op_1_0320241830",
"op_1_0320241830.mp4",
"op_1_0320241830.avi" # This will trigger the error
]

Fix file path for vdms retriever

Issues

This a bug fix patch for #496

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

N/A

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: BaoHuiling <[email protected]>
@BaoHuiling BaoHuiling requested a review from XuhuiRen as a code owner September 3, 2024 08:32
@BaoHuiling BaoHuiling added this to the v1.0 milestone Sep 3, 2024
@XuhuiRen
Copy link
Collaborator

XuhuiRen commented Sep 4, 2024

please add a test to check the error exception

@BaoHuiling
Copy link
Collaborator Author

please add a test to check the error exception

In the corresponding test script?

@XuhuiRen
Copy link
Collaborator

XuhuiRen commented Sep 4, 2024

please add a test to check the error exception

In the corresponding test script?

yes, it would be better to check the availability of the error exception for the wrong file name

@BaoHuiling
Copy link
Collaborator Author

please add a test to check the error exception

In the corresponding test script?

yes, it would be better to check the availability of the error exception for the wrong file name

Test added with CI check passed🙂

@BaoHuiling
Copy link
Collaborator Author

@lvliang-intel @ftian1 Would you help to check and approve the PR? Thanks a lot

@lvliang-intel lvliang-intel merged commit 54aa943 into opea-project:main Sep 4, 2024
9 checks passed
@BaoHuiling BaoHuiling deleted the rerank-fix branch September 5, 2024 01:22
lkk12014402 pushed a commit that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants