-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for PR 496 to add format_video_name function #602
Conversation
Signed-off-by: BaoHuiling <[email protected]>
for more information, see https://pre-commit.ci
please add a test to check the error exception |
In the corresponding test script? |
yes, it would be better to check the availability of the error exception for the wrong file name |
Signed-off-by: BaoHuiling <[email protected]>
for more information, see https://pre-commit.ci
Test added with CI check passed🙂 |
Signed-off-by: BaoHuiling <[email protected]>
@lvliang-intel @ftian1 Would you help to check and approve the PR? Thanks a lot |
Signed-off-by: chensuyue <[email protected]>
Description
Extend rerank functionality to support handle unregular names with video name format function, for example names as follow
[
"op_1_0320241830_interval_0",
"op_1_0320241830",
"op_1_0320241830.mp4",
"op_1_0320241830.avi" # This will trigger the error
]
Fix file path for vdms retriever
Issues
This a bug fix patch for #496
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
Describe the tests that you ran to verify your changes.