Remove redundant dependency from 'vllm-ray' comps #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abolfazl Shahbazi <[email protected]>
chensuyue
approved these changes
Aug 22, 2024
lvliang-intel
approved these changes
Aug 22, 2024
chensuyue
pushed a commit
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Abolfazl Shahbazi <[email protected]> (cherry picked from commit 068527d) Signed-off-by: chensuyue <[email protected]>
tileintel
pushed a commit
to siddhivelankar23/GenAIComps
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Abolfazl Shahbazi <[email protected]> Signed-off-by: siddhivelankar23 <[email protected]>
sharanshirodkar7
pushed a commit
to predictionguard/pg-GenAIComps
that referenced
this pull request
Sep 3, 2024
Signed-off-by: Abolfazl Shahbazi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
langservewas previously removed from allrequirements.txtfiles and was added torequirements-runtime.txt.If there's still a need for that, it can be installed at runtime.
But looking at this
comps/llms/text-generation/vllm-ray/docker/Dockerfile.microservicethere's noCMDorENTRYPOINTto begin with.That means the dependency may not even be needed.
Issues
N/A
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
TBD