Fix CI test changed file detect issue #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chensuyue <[email protected]>
chensuyue
force-pushed
the
suyue/up_ci
branch
2 times, most recently
from
794a53b to
6ee903d
Compare
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
4 tasks
kevinintel
approved these changes
Aug 18, 2024
lvliang-intel
approved these changes
Aug 18, 2024
srinarayan-srikanthan
pushed a commit
to siddhivelankar23/GenAIComps
that referenced
this pull request
Aug 21, 2024
* update wf Signed-off-by: chensuyue <[email protected]> * for test Signed-off-by: chensuyue <[email protected]> * remove test code Signed-off-by: chensuyue <[email protected]> --------- Signed-off-by: chensuyue <[email protected]>
tileintel
pushed a commit
to siddhivelankar23/GenAIComps
that referenced
this pull request
Aug 22, 2024
* update wf Signed-off-by: chensuyue <[email protected]> * for test Signed-off-by: chensuyue <[email protected]> * remove test code Signed-off-by: chensuyue <[email protected]> --------- Signed-off-by: chensuyue <[email protected]> Signed-off-by: siddhivelankar23 <[email protected]>
sharanshirodkar7
pushed a commit
to predictionguard/pg-GenAIComps
that referenced
this pull request
Sep 3, 2024
* update wf Signed-off-by: chensuyue <[email protected]> * for test Signed-off-by: chensuyue <[email protected]> * remove test code Signed-off-by: chensuyue <[email protected]> --------- Signed-off-by: chensuyue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original used
base_commit=${{ github.event.pull_request.base.sha }}is freeze when the PR is created. So if the main branch has new changes, the changed files detect will be wrong. For example, b1f5dd7, https://github.com/opea-project/GenAIComps/actions/runs/10414092982/job/28842520622. So many unnecessary test are triggered.Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.