-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image in docker compose yaml to use the built docker image tag from the README #498
Merged
ashahba
merged 6 commits into
opea-project:main
from
HarshaRamayanam:hramayan/fix_docker_compose
Aug 16, 2024
Merged
Fix image in docker compose yaml to use the built docker image tag from the README #498
ashahba
merged 6 commits into
opea-project:main
from
HarshaRamayanam:hramayan/fix_docker_compose
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ray_serve:habana` doesn't exist (yet) in docker hub
Update README.md
Signed-off-by: Harsha Ramayanam <[email protected]>
ashahba
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
chensuyue
approved these changes
Aug 16, 2024
srinarayan-srikanthan
pushed a commit
to siddhivelankar23/GenAIComps
that referenced
this pull request
Aug 21, 2024
…om the README (opea-project#498) * Update README.md The `ray_serve:habana` doesn't exist (yet) in docker hub * Fixed the image in docker compose yaml Signed-off-by: Harsha Ramayanam <[email protected]> --------- Signed-off-by: Harsha Ramayanam <[email protected]> Co-authored-by: chen, suyue <[email protected]>
tileintel
pushed a commit
to siddhivelankar23/GenAIComps
that referenced
this pull request
Aug 22, 2024
…om the README (opea-project#498) * Update README.md The `ray_serve:habana` doesn't exist (yet) in docker hub * Fixed the image in docker compose yaml Signed-off-by: Harsha Ramayanam <[email protected]> --------- Signed-off-by: Harsha Ramayanam <[email protected]> Co-authored-by: chen, suyue <[email protected]> Signed-off-by: siddhivelankar23 <[email protected]>
sharanshirodkar7
pushed a commit
to predictionguard/pg-GenAIComps
that referenced
this pull request
Sep 3, 2024
…om the README (opea-project#498) * Update README.md The `ray_serve:habana` doesn't exist (yet) in docker hub * Fixed the image in docker compose yaml Signed-off-by: Harsha Ramayanam <[email protected]> --------- Signed-off-by: Harsha Ramayanam <[email protected]> Co-authored-by: chen, suyue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The image mentioned in the docker compose yaml file,
opea/gen-ai-comps:llm-tgi-server
cannot be pulled as it says it doesn't exist yet -So, replacing it with the
opea/llm-tgi:latest
from the README hereNote: The other README update in this PR is related to this PR which is already posted for review
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
I re-ran the docker compose yaml with the replaced image and it worked fine.