Add RagAgentDocGrader to agent comp #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xuechendi @XuhuiRen Please review. Thanks! |
for more information, see https://pre-commit.ci
Signed-off-by: minmin-intel <[email protected]>
Signed-off-by: minmin-intel <[email protected]>
xuechendi
reviewed
Aug 14, 2024
|
The PR looks good to me, I think we should replace agentic Rag with DocGrader instead of creating a new one. These two looks really similiar, and seems DocGrader is also working on non-openAI API, so do we still need to keep both? |
|
@xuechendi Deleted the old agentic_rag strategy |
XuhuiRen
reviewed
Aug 15, 2024
|
what is the difference between "TextGrader" and "DocumentGrader"? should be better give some introduction in the readme |
1 task
3 tasks
|
@XuhuiRen I added description of DocumentGrader and TextGenerator in the readme in the docgrader subfolder. |
…IComps into agent-comp-dev
for more information, see https://pre-commit.ci
…IComps into agent-comp-dev
for more information, see https://pre-commit.ci
chensuyue
reviewed
Aug 16, 2024
Signed-off-by: minmin-intel <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: minmin-intel <[email protected]>
…IComps into agent-comp-dev
|
Tests with OpenAI LLMs passed on my system. See screen shot below. @chensuyue Let me know if this is sufficient, or you would want me to test OpenAI LLM again in CICD. |
|
@XuhuiRen have changed the docgrader to rag_agent, and I have updated the overall README and the README in the strategy/ragagent/ subfolder, describing the rag agent. The plan is to iterate upon the ragagent strategy if we develop more performant rag agents in future. |
To make sure the function always work, we must add the test into CI/CD, in case it is impact by other PRs. |
XuhuiRen
approved these changes
Aug 19, 2024
srinarayan-srikanthan
pushed a commit
to siddhivelankar23/GenAIComps
that referenced
this pull request
Aug 21, 2024
* set hf_hub to 0.24.0 * add docgrader to agent strategy openai llm code passed * add nonstreaming output for agent * add react langgraph and tests * fix react langchain bug Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix test script Signed-off-by: minmin-intel <[email protected]> * fix bug in test script Signed-off-by: minmin-intel <[email protected]> * update readme and rm old agentic-rag strategy * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update test and docgrader readme * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix bug in test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update rag agent strategy name and update readme Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update test Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: minmin-intel <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
chensuyue
pushed a commit
that referenced
this pull request
Aug 21, 2024
* set hf_hub to 0.24.0 * add docgrader to agent strategy openai llm code passed * add nonstreaming output for agent * add react langgraph and tests * fix react langchain bug Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix test script Signed-off-by: minmin-intel <[email protected]> * fix bug in test script Signed-off-by: minmin-intel <[email protected]> * update readme and rm old agentic-rag strategy * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update test and docgrader readme * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix bug in test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update rag agent strategy name and update readme Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update test Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: minmin-intel <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 368c833) Signed-off-by: chensuyue <[email protected]>
tileintel
pushed a commit
to siddhivelankar23/GenAIComps
that referenced
this pull request
Aug 22, 2024
* set hf_hub to 0.24.0 * add docgrader to agent strategy openai llm code passed * add nonstreaming output for agent * add react langgraph and tests * fix react langchain bug Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix test script Signed-off-by: minmin-intel <[email protected]> * fix bug in test script Signed-off-by: minmin-intel <[email protected]> * update readme and rm old agentic-rag strategy * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update test and docgrader readme * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix bug in test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update rag agent strategy name and update readme Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update test Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: minmin-intel <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: siddhivelankar23 <[email protected]>
sharanshirodkar7
pushed a commit
to predictionguard/pg-GenAIComps
that referenced
this pull request
Sep 3, 2024
* set hf_hub to 0.24.0 * add docgrader to agent strategy openai llm code passed * add nonstreaming output for agent * add react langgraph and tests * fix react langchain bug Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix test script Signed-off-by: minmin-intel <[email protected]> * fix bug in test script Signed-off-by: minmin-intel <[email protected]> * update readme and rm old agentic-rag strategy * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update test and docgrader readme * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix bug in test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update rag agent strategy name and update readme Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update test Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: minmin-intel <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new agent strategy for agentic RAG
Issues
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
Need OpenAI LLM for difficult queries. Simple queries can be solved by open-source LLMs.
Tests
Unit test in GenAIComps/tests/