Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation failure without exit. #460

Merged
merged 11 commits into from
Aug 13, 2024
Merged

Fix validation failure without exit. #460

merged 11 commits into from
Aug 13, 2024

Conversation

ZePan110
Copy link
Collaborator

@ZePan110 ZePan110 commented Aug 12, 2024

Description

The summary of the proposed changes as long as the relevant motivation and context.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@ZePan110 ZePan110 requested a review from XuhuiRen as a code owner August 12, 2024 09:13
@ZePan110 ZePan110 merged commit f46f1f3 into main Aug 13, 2024
11 checks passed
@ZePan110 ZePan110 deleted the result_check-new branch August 13, 2024 02:10
BaoHuiling pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 15, 2024
* Fix validation failure without exit.

Signed-off-by: zepan <[email protected]>

* Change validate log.

Signed-off-by: zepan <[email protected]>

* Fix validation failure without exit.

Signed-off-by: zepan <[email protected]>

* Change validate log.

Signed-off-by: zepan <[email protected]>

* Change validate log.

Signed-off-by: zepan <[email protected]>

* Fix issue for reranking-langchain-mosec.

Signed-off-by: zepan <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix script issue

Signed-off-by: zepan <[email protected]>

---------

Signed-off-by: zepan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
BaoHuiling pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 15, 2024
* Fix validation failure without exit.

Signed-off-by: zepan <[email protected]>

* Change validate log.

Signed-off-by: zepan <[email protected]>

* Fix validation failure without exit.

Signed-off-by: zepan <[email protected]>

* Change validate log.

Signed-off-by: zepan <[email protected]>

* Change validate log.

Signed-off-by: zepan <[email protected]>

* Fix issue for reranking-langchain-mosec.

Signed-off-by: zepan <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix script issue

Signed-off-by: zepan <[email protected]>

---------

Signed-off-by: zepan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: BaoHuiling <[email protected]>
tileintel pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 22, 2024
* Fix validation failure without exit.

Signed-off-by: zepan <[email protected]>

* Change validate log.

Signed-off-by: zepan <[email protected]>

* Fix validation failure without exit.

Signed-off-by: zepan <[email protected]>

* Change validate log.

Signed-off-by: zepan <[email protected]>

* Change validate log.

Signed-off-by: zepan <[email protected]>

* Fix issue for reranking-langchain-mosec.

Signed-off-by: zepan <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix script issue

Signed-off-by: zepan <[email protected]>

---------

Signed-off-by: zepan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: siddhivelankar23 <[email protected]>
sharanshirodkar7 pushed a commit to predictionguard/pg-GenAIComps that referenced this pull request Sep 3, 2024
* Fix validation failure without exit.

Signed-off-by: zepan <[email protected]>

* Change validate log.

Signed-off-by: zepan <[email protected]>

* Fix validation failure without exit.

Signed-off-by: zepan <[email protected]>

* Change validate log.

Signed-off-by: zepan <[email protected]>

* Change validate log.

Signed-off-by: zepan <[email protected]>

* Fix issue for reranking-langchain-mosec.

Signed-off-by: zepan <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix script issue

Signed-off-by: zepan <[email protected]>

---------

Signed-off-by: zepan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants