Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in updating embedding & reranking model to bge-large-zh-v1.5 #410

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

ftian1
Copy link
Collaborator

@ftian1 ftian1 commented Aug 5, 2024

Description

The PR is used to fix some typos in #387

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

n/a

Tests

local test pass

@ftian1 ftian1 requested a review from XuhuiRen as a code owner August 5, 2024 08:22
@lvliang-intel lvliang-intel merged commit da19c5d into main Aug 5, 2024
9 checks passed
@lvliang-intel lvliang-intel deleted the ftian/fix_typo branch August 5, 2024 08:38
sharanshirodkar7 pushed a commit to predictionguard/pg-GenAIComps that referenced this pull request Aug 7, 2024
yogeshmpandey pushed a commit to yogeshmpandey/GenAIComps that referenced this pull request Aug 9, 2024
BaoHuiling pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants