Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Uvicorn dependency #408

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

lvliang-intel
Copy link
Collaborator

Description

Add Uvicorn dependency

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

uvicorn

Tests

Pre-CI test

Signed-off-by: lvliang-intel <[email protected]>
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@chensuyue
Copy link
Collaborator

chensuyue commented Aug 5, 2024

The issue caused by the new release of fastapi. The new version of fastapi don't depend on uvicorn any more, so it won't be installed as a second level deps by default.
image
image

@chensuyue chensuyue merged commit b2e2b1a into opea-project:main Aug 5, 2024
8 checks passed
sharanshirodkar7 pushed a commit to predictionguard/pg-GenAIComps that referenced this pull request Aug 7, 2024
Signed-off-by: lvliang-intel <[email protected]>
Signed-off-by: sharanshirodkar7 <[email protected]>
lkk12014402 pushed a commit that referenced this pull request Aug 8, 2024
yogeshmpandey pushed a commit to yogeshmpandey/GenAIComps that referenced this pull request Aug 9, 2024
BaoHuiling pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 15, 2024
Signed-off-by: lvliang-intel <[email protected]>
Signed-off-by: BaoHuiling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants