Redis-dataprep: Make Redis connection consistent #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are both 'from langchain_community.vectorstores import Redis' and 'import redis' in prepare_doc_redis.py. Redis.from_texts_return_keys() is with REDIS_URL as connection, while redis.Redis() takes the combination of REDIS_HOST and REDIS_PORT as connection. When the former and the latter are not the same, it will fail to get data from vector database. Change to use REDIS_URL as the unified way. Signed-off-by: Cathy Zhang <[email protected]>
|
Please fix the confict with main branch |
Spycsh
approved these changes
Jul 30, 2024
letonghan
approved these changes
Jul 30, 2024
sharanshirodkar7
pushed a commit
to predictionguard/pg-GenAIComps
that referenced
this pull request
Aug 6, 2024
There are both 'from langchain_community.vectorstores import Redis' and 'import redis' in prepare_doc_redis.py. Redis.from_texts_return_keys() is with REDIS_URL as connection, while redis.Redis() takes the combination of REDIS_HOST and REDIS_PORT as connection. When the former and the latter are not the same, it will fail to get data from vector database. Change to use REDIS_URL as the unified way. Signed-off-by: Cathy Zhang <[email protected]> Co-authored-by: Sihan Chen <[email protected]> Signed-off-by: sharanshirodkar7 <[email protected]>
sharanshirodkar7
pushed a commit
to predictionguard/pg-GenAIComps
that referenced
this pull request
Aug 7, 2024
There are both 'from langchain_community.vectorstores import Redis' and 'import redis' in prepare_doc_redis.py. Redis.from_texts_return_keys() is with REDIS_URL as connection, while redis.Redis() takes the combination of REDIS_HOST and REDIS_PORT as connection. When the former and the latter are not the same, it will fail to get data from vector database. Change to use REDIS_URL as the unified way. Signed-off-by: Cathy Zhang <[email protected]> Co-authored-by: Sihan Chen <[email protected]> Signed-off-by: sharanshirodkar7 <[email protected]>
BaoHuiling
pushed a commit
to siddhivelankar23/GenAIComps
that referenced
this pull request
Aug 15, 2024
There are both 'from langchain_community.vectorstores import Redis' and 'import redis' in prepare_doc_redis.py. Redis.from_texts_return_keys() is with REDIS_URL as connection, while redis.Redis() takes the combination of REDIS_HOST and REDIS_PORT as connection. When the former and the latter are not the same, it will fail to get data from vector database. Change to use REDIS_URL as the unified way. Signed-off-by: Cathy Zhang <[email protected]> Co-authored-by: Sihan Chen <[email protected]> Signed-off-by: BaoHuiling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are both 'from langchain_community.vectorstores import Redis' and 'import redis' in prepare_doc_redis.py. Redis.from_texts_return_keys() is with REDIS_URL as connection, while redis.Redis() takes the combination of REDIS_HOST and REDIS_PORT as connection. When the former and the latter are not the same, it will fail to get data from vector database. Change to use REDIS_URL as the unified way.
Description
The summary of the proposed changes as long as the relevant motivation and context.
Issues
tofix: #358
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a
Tests
Verify by 'kubectl apply -f chatqna.yaml' and then follow custome API to check Upload/Get/Delete APIs.