embeddings: adaptive detect embedding model arguments in mosec #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jincheng Miao <[email protected]>
for more information, see https://pre-commit.ci
ftian1
approved these changes
Jul 12, 2024
lvliang-intel
approved these changes
Jul 15, 2024
dwhitena
pushed a commit
to predictionguard/GenAIComps
that referenced
this pull request
Jul 24, 2024
…project#296) * embeddings: adaptive detect embedding model arguments in mosec Signed-off-by: Jincheng Miao <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Jincheng Miao <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Daniel Whitenack <[email protected]>
berkecanrizai
pushed a commit
to berkecanrizai/GenAIComps
that referenced
this pull request
Jul 29, 2024
…project#296) * embeddings: adaptive detect embedding model arguments in mosec Signed-off-by: Jincheng Miao <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Jincheng Miao <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Berke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Difference embedding model may have different input arguments.
This patch adaptively detect model arguments.
Issues
n/aType of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
'n/a'.
Tests
Use EMB_MODEL environ to switch to different embedding models.
Bge-large-zh and bce-embedding-base-v1 is tested locally.