Add ML detection strategy to PII detection guardrail #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xuechendi @XuhuiRen @ftian1 Please review. Thanks! |
|
@minmin-intel , test bash script is located here: https://github.com/opea-project/GenAIComps/blob/main/tests/test_guardrails_pii_detection.sh you can move content of run_test.sh to above file |
xuechendi
reviewed
Jul 10, 2024
Thanks for pointing this out! I have moved the tests to test_guardrails_pii_detection.sh |
|
hello, @minmin-intel , UT failed, I think you hard coded IP addr?
|
Signed-off-by: minmin-intel <[email protected]>
XuhuiRen
reviewed
Jul 30, 2024
XuhuiRen
reviewed
Jul 30, 2024
XuhuiRen
reviewed
Jul 30, 2024
XuhuiRen
reviewed
Jul 30, 2024
XuhuiRen
reviewed
Jul 30, 2024
XuhuiRen
reviewed
Jul 30, 2024
Signed-off-by: minmin-intel <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: minmin-intel <[email protected]>
for more information, see https://pre-commit.ci
XuhuiRen
approved these changes
Aug 1, 2024
sharanshirodkar7
pushed a commit
to predictionguard/pg-GenAIComps
that referenced
this pull request
Aug 7, 2024
* first code of business safety classifier * allow strategy options and update readme * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * disable ray for ml strategy and update test script * add log to pii test Signed-off-by: minmin-intel <[email protected]> * update logging in test gaurdrail * rm llm strategy and change url in test Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * delete file check in test and update readme Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: minmin-intel <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: chen, suyue <[email protected]> Signed-off-by: sharanshirodkar7 <[email protected]>
lkk12014402
pushed a commit
that referenced
this pull request
Aug 8, 2024
Signed-off-by: zepan <[email protected]>
BaoHuiling
pushed a commit
to siddhivelankar23/GenAIComps
that referenced
this pull request
Aug 15, 2024
* first code of business safety classifier * allow strategy options and update readme * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * disable ray for ml strategy and update test script * add log to pii test Signed-off-by: minmin-intel <[email protected]> * update logging in test gaurdrail * rm llm strategy and change url in test Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * delete file check in test and update readme Signed-off-by: minmin-intel <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: minmin-intel <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: chen, suyue <[email protected]> Signed-off-by: BaoHuiling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a second strategy to the pii detection guardrail microservice where a logistic regression classifier is used to detect PIIs.
Issues
NA
Type of change
Dependencies
scikit-learn
Tests
microservice-level unit test. see the script
run_test.sh