Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parameter for retriever #159

Merged
merged 8 commits into from
Jun 19, 2024
Merged

Conversation

Liangyx2
Copy link
Collaborator

@Liangyx2 Liangyx2 commented Jun 13, 2024

Description

Use parameter for retriever

Issues

n/a.

Type of change

  • Breaking change (fix or feature that would break existing design and interface)

Tests

Pass

@Liangyx2 Liangyx2 marked this pull request as draft June 17, 2024 02:04
@kevinintel
Copy link
Collaborator

Please fix conflict and add low-code configuration for data ingestion

@kevinintel kevinintel linked an issue Jun 17, 2024 that may be closed by this pull request
@Liangyx2 Liangyx2 closed this Jun 17, 2024
@Liangyx2 Liangyx2 force-pushed the yuxiang/retriever branch from 313237c to 011bfbd Compare June 17, 2024 08:18
Signed-off-by: Liangyx2 <[email protected]>
@Liangyx2 Liangyx2 reopened this Jun 17, 2024
@Liangyx2 Liangyx2 marked this pull request as ready for review June 17, 2024 08:31
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
comps/cores/proto/docarray.py 100.00% <100.00%> (ø)

@Liangyx2 Liangyx2 mentioned this pull request Jun 17, 2024
1 task
@Liangyx2 Liangyx2 marked this pull request as draft June 18, 2024 03:56
@Liangyx2 Liangyx2 marked this pull request as ready for review June 18, 2024 06:21
@Liangyx2 Liangyx2 marked this pull request as draft June 18, 2024 08:20
@Liangyx2 Liangyx2 marked this pull request as ready for review June 18, 2024 08:21
@kevinintel kevinintel merged commit 358dbd6 into opea-project:main Jun 19, 2024
18 of 19 checks passed
sharanshirodkar7 pushed a commit to sharanshirodkar7/GenAIComps that referenced this pull request Jul 9, 2024
* fix

Signed-off-by: Liangyx2 <[email protected]>

for more information, see https://pre-commit.ci

---------

Signed-off-by: Liangyx2 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: sharanshirodkar7 <[email protected]>
lkk12014402 pushed a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataPrep low-code configuration for data ingestion
4 participants