Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aio orchestrator to boost concurrent serving #130

Merged
merged 7 commits into from
Jun 3, 2024

Conversation

Spycsh
Copy link
Member

@Spycsh Spycsh commented Jun 3, 2024

Description

This PR

  • allow subsequent requests to be handled non-blocking in earlier microservices concurrently
  • allow microservices on DAG branches to be handled concurrently

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

aiohttp

Tests

add a local test

also with GenAIEval, evals/benchmark/chatqna_benchmark.py

The data shows a ~1.5x speedup for P99 latency with total concurrent number of requests: 2,4,8,16,32,64

Copy link
Collaborator

@hshen14 hshen14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive!

@lvliang-intel lvliang-intel merged commit db3b4f1 into opea-project:main Jun 3, 2024
15 checks passed
ganesanintel pushed a commit to ganesanintel/GenAIComps that referenced this pull request Jun 3, 2024
* aio scheduler

* fix test

Signed-off-by: Spycsh <[email protected]>

* ix req

* fix streaming

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix

---------

Signed-off-by: Spycsh <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Signed-off-by: V, Ganesan <[email protected]>
XinyuYe-Intel pushed a commit that referenced this pull request Jun 17, 2024
* aio scheduler

* fix test

Signed-off-by: Spycsh <[email protected]>

* ix req

* fix streaming

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix

---------

Signed-off-by: Spycsh <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants