-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize BaseStatistics code a bit + document it #1107
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Eero Tamminen <[email protected]>
Setting as draft, until I've done more testing on it. |
Codecov ReportAttention: Patch coverage is
|
Hm. It appears that statistics output is not tested, so none of the code I changed is covered. Because my refactoring removed more code than it added, the overall coverage should have improved though. |
Was hard finding a microservice providing these metrics. None of "DocSum" ones provided them, but "ChatQnA" had one. It works the same before and after the change:
|
Thanks for adding documentation. Could you also add the test to cover your code? There is a very simple test of this functionality here https://github.com/eero-t/GenAIComps/blob/stats/tests/cores/mega/test_base_statistics.py. You can add some unit test there to for coverage. (The original test init a server so the code is not detected by the coverage test I guess). |
Description
Generalize BaseStatistics code a bit + document it.
Issues
n/a
.Type of change
Dependencies
n/a
.Tests
Pylint likes the change, and I manually checked ChatQnA microservice before and after the change.